-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling to the right end results in shift between header and body #2521
Comments
There were some substantial changes went into scrolling yesterday, which should have fixed some of these issues (or perhaps they newly created this?). Could you perhaps check again? |
This still exists, and was introduced with the 30df7d4 merge, which also appears to have broken both Similarly, the vertical row selection header is now misaligned when you scroll all the way to the bottom. |
Just confirming the issue is still present in 97dbff8 |
I am still seeing this with the latest unstable. |
@axelstudios I'm not positive this was introduced with 30df7d4 (Jan 8) if only because I'm still on RC18 (Dec 9) and I'm noticing this same misalignment. Possibly there are multiple causes of the issue. In my case it would only appear when the user horizontally scrolled the grid due to large datasets. My misalignment was solved when I assigned a class with a width to my |
For me, this bug is gone with the latest unstable. |
This bug still exists for me with latest unstable and rc19. |
@sachinny21 OK I'll take a look |
thanks cobra! |
I'm still seeing something like this in 1fdcf3d in current master, although the behaviour for me is different. I have a lot of columns, and as I scroll, periodically entire headers vanish and leave with fewer headers than columns. Not sure if this is identical in cause: I'll see if I can pin down the commit as it wasn't there in rc16. |
Okay, the issue I've seen is in 893bb13 (fix(uiGridHeader): Fix dynamic header heights), and therefore it isn't the same. Taking a wild guess, it's the lines which take away the min-height constraint on header cells allowing them to collapse away entirely when there are too many to fit. I'll try to build a small example to demonstrate. |
@morungos Any luck on making that example? Can you tell me if you're having issues in a particular browser. I know that table-based CSS can be a bit wonky between different browsers and versions. |
@c0bra Sadly no -- my app is in healthcare, so I just didn't get time to remove all the bits I needed to, and there were too many weird requests from my users to sustain with the current status of ui-grid, so I've switched for now to handsontable for now, which isn't as clean an API but does seem to handle the basic UI/scrolling/editing well, if without the scalability I'll need some day. |
Ah, I understand. Thanks for the info on this issue, though. I'll look into the column collapsing thing. |
Since there have been so many changes to scrolling recently I'm going to close this as the only thing left was a difficult-to-repro column collapsing issue. If it's still a problem after the scrolling changes I trust it will be filed again. |
I thought this was completely gone until I received screenshots of this on IE9. Really can't blame anyone for not wanting to deal w/ that browser though. |
I'm having this exact issue in IE9. It is the same in 20 and 21. It seems to work fine when only a few columns are displayed - but has problems when there are more and it has to scroll |
I see the issue in IE9 when I set the column width narrower than the text of the heading will allow. Chrome is fine with the Some detail (it might help): Setting the width on the Sadly I'm in "git 'er done" mode so I just need to make it work. Maybe someone else is and will find this helpful. Without a doubt I will suffer in Hell for this. |
@bernhard-hofmann after re-reading @c0bra's comment, it might be necessary to open a new issue for this IE9 issue to be considered. Not sure the policy on reopening closed issues. |
We have a requirement that some of our webapps allow a reasonable amount of zoom in and zoom out say like from 80% to 150% in a browser window. We're seeing this behavior on browser zoom in/out. Meaning alignment between column header and body gets worse towards the right end. I believe we're also using 3.0.7. Thanks for your efforts with ui-grid. Very much appreciated. |
I had the same issue in IE9 and i Solve Setting the same width of the title like width the collum. If the width of the collum was less than width of the size of the title the problem occours in ie9. |
Still i am facing the issue @c0bra |
I have the same issue, I have the latest release 3.2.6 |
The width of your collum has to have the size of your title. If your value is lowwer the problem occours. |
Hope everyone can solve this problem with this tip. First, add class on last column header when vertical scrollbar needed.
And add below lines on style sheet. Assume that scroll width is 20px.
|
Same issue I faced in Kendo Grid, solved using this trick:- http://www.letmeknows.com/2017/03/07/header-and-column-data-mis-aligned-after-implementing-in-kendo-grid |
When reaching the right end of the grid the header columns and the data columns are not properly aligned. See for example on the homepage:
I suspect this example shouldn't scroll (and the one below definitely shouldn't).
It seems the header row and the grid have the same canvas width and the same viewport width but the grid has the vertical scrollbar.
It doesn't happen in commit d9b2314 so it's been introduced after that. Maybe the scrollbar width was added to the grid canvas width somewhere and it should have been removed when changing the way scroll works ?
The text was updated successfully, but these errors were encountered: