Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with vertical scroll bar hidding the column data #3157

Closed
AdityaJitu opened this issue Mar 30, 2015 · 13 comments
Closed

Issue with vertical scroll bar hidding the column data #3157

AdityaJitu opened this issue Mar 30, 2015 · 13 comments

Comments

@AdityaJitu
Copy link

Hi,
Initially when the grid is loaded then the rightmost column is displayed properly. But when I resize the grid & then the scroll-bar overlaps the contents of the right-most(last) column.
I am attaching the screenshot of the issue that I encountered.

As of now I am using this version.
ui-grid - v3.0.0-RC.18-92a8836 - 2014-12-25
issue

I am highlighting the issue.

issue

We are showing the scrollbars conditionally using

enableHorizontalScrollbar:uiGridConstants.scrollbars.WHEN_NEEDED,
enableVerticalScrollbar:uiGridConstants.scrollbars.WHEN_NEEDED

@yurigenin
Copy link

I do not think WHEN_NEEDED is implemented though. Last time I checked the source code it was not used anywhere.

@c0bra
Copy link
Contributor

c0bra commented Mar 30, 2015

@AdityaJitu Please update to the latest RC. This has been fixed in versions newer than the one you're using.

@yurigenin
Copy link

Well, I'm using the latest one and the issue is still there. I do not think it is an issue actually but by design. Unless somebody thinks it is a bug.

@c0bra
Copy link
Contributor

c0bra commented Mar 31, 2015

@yurigenin The issue should be fixed as of this commit: cf86090 Can you reproduce the problem in a plunker?

@yurigenin
Copy link

Even your tutorials do not work now and the same plunker in the original case has the same behavior. The plunker is using unstable as all your tutorials...

From: Brian Hann notifications@github.com
To:angular-ui/ng-grid ng-grid@noreply.github.com
CC:yurigenin yurig@netiq.com
Date: 3/31/2015 9:40 AM
Subject: Re: [ng-grid] Issue with vertical scroll bar hidding the column data (#3157)

@yurigenin The issue should be fixed as of this commit: cf86090 Can you reproduce the problem in a plunker?


Reply to this email directly or view it on GitHub.

@c0bra
Copy link
Contributor

c0bra commented Mar 31, 2015

@yurigenin What are you talking about? What plunker? There is no plunker linked in this issue.

What tutorial are you referring to?

@yurigenin
Copy link

#3138. The original one you closed. There is a plunker there. Go to any tutorial like this:

http://ui-grid.info/docs/#/tutorial/210_selection

And try to use it. Do you see a selection header? Do you see any menus?

That's what I'm talking about.

Thanks,

Yuri

From: Brian Hann notifications@github.com
To:angular-ui/ng-grid ng-grid@noreply.github.com
CC:yurigenin yurig@netiq.com
Date: 3/31/2015 9:48 AM
Subject: Re: [ng-grid] Issue with vertical scroll bar hidding the column data (#3157)

@yurigenin What are you talking about? What plunker? There is no plunker linked in this issue.

What tutorial are you referring to?


Reply to this email directly or view it on GitHub.

@c0bra
Copy link
Contributor

c0bra commented Mar 31, 2015

@yurigenin That's a completely separate issue from this one. This issue is about the scrollbar hiding cell contents. Your issue is about icons not being visible on the tutorials. You already filed an issue (four separate issues in fact) for that.

@yurigenin
Copy link

You are right, it is a separate issue. The issue I was talking about (#3138) was closed before I could test. I added several comments to it asking to reopen but nobody replied. No, my issue is not about icons. My issue is this:

Filter widgets (controls) do not show up if filtering is enabled dynamically #3138

Since nobody replied to my requests to reopen I had to open other ones. Anyway, if you are saying the issue #3138 is resolved, then everything is honky dorky. Except it is not resolved, thus, this thread.

@yurigenin That's a completely separate issue from this one. This issue is about the scrollbar hiding cell contents. Your issue is about icons not being visible on the tutorials. You already filed an issue (four separate issues in fact) for that.


Reply to this email directly or view it on GitHub.

@AdityaJitu
Copy link
Author

Hi @c0bra , @yurigenin ,

Thank you for your comments. I will use the latest release & verify it again.

With Regards,
Aditya Padhi

@c0bra
Copy link
Contributor

c0bra commented Mar 31, 2015

@yurigenin @AdityaJitu this should be fixed now. Broken tests were preventing the build from completing.

@AdityaJitu
Copy link
Author

Hi @c0bra ,

It is working fine now. The issue arises rarely. I got this issue when I try to resize the browser by dragging the browser edges or by clicking the "restore button" of the browser. It does not happen frequently though.

@PaulL1
Copy link
Contributor

PaulL1 commented Apr 21, 2015

Sounds like this is resolved. Closing.

@PaulL1 PaulL1 closed this as completed Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants