[moveColumn] Sorting by clicking column header broken - triggering move instead

[brockj]

I think this was introduced in the last few days, but clicking on the header to sort a column no longer works
you can see this in http://ui-grid.info/docs/#/tutorial/102_sorting
Clicking on the name/gender columns has no effect, but using the menu works

I will try to isolate the change that caused this. I am currently on 7df7234

[brockj]

This is super strange. It only appears on Chrome and restarting the browser a few times made the issue go away. Chrome version is 42.0311.90.m

please close if you can't reproduce

[PaulL1]

It's working for me, but I'll leave it open and see if anyone else has issues.

[StanislavPrusac]

Sorting by click with mouse at header still is not working.
I tested at link : http://ui-grid.info/docs/#/tutorial/102_sorting and in my application
Sometime when start fresh Google Chrome, working but after refresh this same page stopped.
Working normal in Firefox 37.0.2
Google Chrome: Version 42.0.2311.135 m (64-bit)
Windows 7
Angular-ui-grid,version: 3.0.0-rc.21

[sandeeppbajaj]

Yes...its acting weird. It needs to be clicked 2-4 times and it goes through stages asc, desc and no-sorting.

[enigmak]

It looks like chrome calls the move function when the mouse has not moved much and the other browsers do not.

Changing the downFn to track the event.pageX and then checking it in the moveFn will correct this.

So in the downFn add the $scope.previousMouseX = event.pageX;

              $scope.mousedownStartTime = (new Date()).getTime();
              $scope.mousedownTimeout = $timeout(function() { }, mousedownTimeout);
              $scope.previousMouseX = event.pageX;

Then in the move function check for movement.

            $scope.moveFn = function( event ){
              var xMove = $scope.previousMouseX - event.pageX;

              // If we haven't moved let mouse up call fire.
              if (xMove !== 0) {
                // we're a move, so do nothing and leave for column move (if enabled) to take over
                $timeout.cancel($scope.mousedownTimeout);
                $scope.offAllEvents();
                $scope.onDownEvents(event.type);
              }
            };

[PaulL1]

OK, I did the work on the downFn and move stuff, so I guess I get to fix this.

[Zorkling]

@enigmak You can also acomplish this by just varing up a previousMoveX and setting it during the down event handling. Since the drag activation only needs to happen once, and the previous move can be reset on any down event, theres no need for timers. Misread your comment, thats more or less exactly what i have in the PR, only that there needs to be handling in column-move.js as well as ui-grid-header-cell.js

@PaulL1 Would you like me to make a PR for this? I had messed with it previously but hadnt gotten around to commiting the fix

[PaulL1]

@Zorkling : that would be useful.

[Zorkling]

@PaulL1 Pull request ready, my bad for the double commit, got too hasty with the push

In case anyone is curious, the issue has existed for almost a couple of years, heres a chromium issue that describes alot of the behavior around it
https://code.google.com/p/chromium/issues/detail?id=327114