-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misalignment between the grid content and the select checkbox column #3394
Comments
I just ran into this also, but updating to RC21 solved it. |
I have this issue also. Only surfaced since updating to RC21, and the demo has the same issue; it's using RC21 too. |
how can fix this? |
I tried reproducing this in a plunkr, and cannot do so consistently. I got the issue to appear once, but can't get it to show up again after refreshing. Will someone please provide a provide a plunkr which demonstrates the problem (please specify your browser version and platform also). |
This seems to be the same bug detailed in #3412 |
@JayHuang, I believe this is not the same bug as #3412. I have not looked in more detail at where this is generated, but problem has to do with the css which is generated and inserted into a style element. I just observed this on the Grouping tutorial page. This is the offending line:
On a grid which is displaying properly, this selector has height set to a pixel value. |
Refactor setting of header heights to be more DRY and ensure that rebuildStyles is set when an explicit height is set. Do not set existing explicit heights to null before recalculating height. Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
Refactor setting of header heights to be more DRY and ensure that rebuildStyles is set when an explicit height is set. Do not set existing explicit heights to null before recalculating height. Fixes: angular-ui#3394, angular-ui#3382, angular-ui#3409
Would this be related? I have a grid when we resize or sort any of the colums the Select all checkbox collapses moving up the other checkboxs so they are not aligned correctly w/ the row. Only seems to be happening when enableSelectAll set to false. Grid config:
|
I think this is the issue that @AgDude has tied all the various height issues to. Basically any column without a filter will get out of alignment, which is caused by the header height calculation changes. I thought we'd reverted and/or fixed this, but it's still doing it on the all features tutorial: http://ui-grid.info/docs/#/tutorial/401_AllFeatures @anwarhamr : I think your issue may be different, it sounds like an issue with the selectAll header getting messed up. Does it only do it to you when enableSelectAll is false, or does it do it irrespective (in which case it is probably a duplicate of this issue). |
That is correct, it works correctly when we allow select all. But this once case we loose the size when we do something else to a different row and the grid redraws Thanks, Rob |
This should be fixed with #3424, which is now merged. Can we confirm? |
Looks solved to me on the tutorials. |
I have the same problem enableSelectAll:false was removed but problem is still going on... ver 4.0.6 |
you can see the live demo here http://ui-grid.info/docs/#/tutorial/401_AllFeatures
The text was updated successfully, but these errors were encountered: