Expand All/Collapse ALL Problem with Tree View

[dereklin]

This issue happens both in the tutorial: http://ui-grid.info/docs/#/tutorial/215_treeView

Or in my plunker: http://plnkr.co/edit/MwhZMkAeioxceQtbChN1?p=preview

When you manually expand individual sub-trees, the Master Tree still shows the + sign. Instead, it should show the - sign, since all sub-trees have been expanded.

Vice Versa for Collapse ALL.

[PaulL1]

Yes, there isn't a check as to whether every tree node is expanded, it drives off whether you clicked expand all or programatically called expand all.

I'm not keen to write a check as to whether every node is expanded - that would get expensive. But I would agree that (I think like grouping) if you have expanded all and you collapse something, then expandAll should toggle back to false.

[dereklin]

When I expand all sub-trees, the master expand/collapse still shows +. It should show - because all sub-trees are already expanded. I might have missed it somewhere in your message. Did you say fixing this will be too expensive and therefore, it won't be fixed or changed?

[PaulL1]

Yes. It would mean iterating over the entire tree on every digest cycle to see whether or not every cell is expanded. If we have a very large data set this will be expensive. Most applications don't do this - you only go to a - if someone explicitly clicks the button (or, in our case, calls expand all programatically).

[dereklin]

Is there an option to hide the master expand/collapse button?

And would it be feasible to keep a tally for number of expanded/collapsed sub-trees on each expand/collapse action, and then just compare the tally with the total number of sub-trees to show/hide the master expand/collapse button?

For now, I think I can just use css to hide the master expand/collapse button.

[PaulL1]

There is not currently an option to hide the button.