Skip to content

Grouping breaks Column Header Height for deferred columnDefs generation #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JLLeitschuh opened this issue May 27, 2015 · 4 comments
Open
Assignees
Milestone

Comments

@JLLeitschuh
Copy link
Contributor

http://plnkr.co/edit/u6LBOx?p=preview
As you can see in this demo if the column header height is wrong when the grouping directive is added to the grid. This is only a problem when the column defs aren't there when the grid options are loaded.
Example:

$timeout(function(){
  var newColumnDefs = [
    { name:'firstName', field: 'first-name', displayName: 'First Name'},
    { name:'1stFriend', field: 'friends[0]', displayName: '1st Friend'},
    { name:'city', field: 'address.city', displayName: 'City'},
    { name:'getZip', field: 'getZip()'}
  ];
  $scope.gridOptions.columnDefs = newColumnDefs;
}, 500);

This problem is not there for the grid without the grouping directive.

When you perform the grouping action the headers appear correctly however when you ungroup they return to their broken state.
OS: Mac OSX
Browser: Chrome
Build: v3.0.0-rc.21-d68dcc6 - 2015-05-27
screen shot 2015-05-27 at 2 19 41 pm

@AgDude
Copy link
Contributor

AgDude commented Jun 2, 2015

I don't think this is specifically related to grouping. This has to do with multiple render containers and no columns. This may be due to my refactor a few weeks ago of the header height calculation, but I am not seeing why. @c0bra would you mind taking a look?

The original plunker doesn't apply notifyDataChange so here is a fork that does, and the problem still occurs: http://plnkr.co/edit/implXX?p=preview

@c0bra
Copy link
Contributor

c0bra commented Jun 2, 2015

Hmm. Not sure, I will take a look. Is this the commit @AgDude? 65ad61f

  • test grouping with delayed columnDefs before and after header height refactor

@c0bra c0bra self-assigned this Jun 2, 2015
@AgDude
Copy link
Contributor

AgDude commented Jun 2, 2015

Yes, that is the commit I am referring to. I haven't tried replicating around the time of the commit.

@JLLeitschuh
Copy link
Contributor Author

Still a bug in 3.0

@JLLeitschuh JLLeitschuh added this to the 3.1 milestone Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants