Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling in subgrid also scrolls parent grid #4156

Closed
SomeKittens opened this issue Aug 11, 2015 · 2 comments · Fixed by #4201
Closed

Scrolling in subgrid also scrolls parent grid #4156

SomeKittens opened this issue Aug 11, 2015 · 2 comments · Fixed by #4201

Comments

@SomeKittens
Copy link
Contributor

Expand subgrid with more entries than vertical space. Attempt to scroll subgrid. Note that parent grid scrolls as well.

Repro found on Retrieve data for subGrid when expanding (furthest one down) here: http://ui-grid.info/docs/#/tutorial/216_expandable_grid

Chrome/OSX

@SomeKittens
Copy link
Contributor Author

@swalters comments:

ok, so with macbook using scrollbar, it works as expected. Using mouse wheel or trackpad, it doesn't.

@SomeKittens
Copy link
Contributor Author

More testing:

Both scroll in Chrome 44 Win 8.1

SomeKittens added a commit to SomeKittens/ui-grid that referenced this issue Aug 15, 2015
…croll

Previously, the stopPropagation function was not on scrollEvent, causing
scrolling in subgrids to also scroll the main grid.  This PR exposes stopProp
and calls it on subgrid scroll

fixes angular-ui#4156
swalters added a commit that referenced this issue Aug 16, 2015
fix(expandable): fix #4156 by calling stopProp on subgrid scroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant