Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinnedRight adding an extra blank column #4949

Closed
AnirudhaGohokar opened this issue Jan 12, 2016 · 4 comments
Closed

pinnedRight adding an extra blank column #4949

AnirudhaGohokar opened this issue Jan 12, 2016 · 4 comments

Comments

@AnirudhaGohokar
Copy link

Hi,

Setting pinnedRight to true is adding an extra blank column to its left.
Here's a plunker for reference: http://plnkr.co/edit/h3TzNPIhFp6BsV4C3PHE?p=preview

Thanks,
Anirudha

@AnirudhaGohokar AnirudhaGohokar changed the title pinnedRight adding an extra blank coloumn pinnedRight adding an extra blank column Jan 12, 2016
@zakerby
Copy link

zakerby commented Nov 30, 2016

Hi,
I have the same issue, it can be quick fixed by modifying the margin of the concerned column but it's not quite elegant....

@mani301
Copy link

mani301 commented Apr 25, 2017

Hi,
I did solved this problem by making certain changes in the updateColumnWidths function of GridRenderContainer. All I have done is added a new variable to find out if there is atleast one pinnedRightColumn is available. If its there, I have just added the scrollbarWidth(which is the exact size of whitespace / extra blank column) to the available width before processColumnUpwards and processColumnDownwards so that white space will be filled up with the columns during auto width specification.

//This is inside iterating for each column
if (!pinRightColumn && column.colDef.pinnedRight) { pinRightColumn = true; }
//Before
if(pinRightColumn) { availableWidth += self.grid.scrollbarWidth; }

I am not quite sure this is correct solution or not, but this does the trick for me and has overwritten that API into my project.

Adding my comment to know whether this is proper fix or not. Can anyone validate this approach, so that I can make a pull request into master.

ronansi added a commit to ronansi/ui-grid that referenced this issue Jun 21, 2017
ronansi added a commit to ronansi/ui-grid that referenced this issue Jun 21, 2017
@ghost
Copy link

ghost commented Sep 19, 2017

Looks like this fix is not in the current version (v4.0.6). It would be great to have a new version (4.0.7?), so it'd be fixed for everyone.

vishalnarewade pushed a commit to vishalnarewade/ui-grid that referenced this issue Nov 6, 2017
vishalnarewade pushed a commit to vishalnarewade/ui-grid that referenced this issue Nov 6, 2017
@Truedison
Copy link

Still experiencing this issue on ui-grid - v4.4.11 - 2018-05-16

jpcleite added a commit to jpcleite/ui-grid that referenced this issue Dec 27, 2022
…inned column

Change the order of conditionals to remove blank space between the last
unpinned column and the pinned right column in order to fix the
availableWidth behavior

This commit fixes angular-ui#4949 (pull angular-ui#6284)
mportuga pushed a commit that referenced this issue Jan 9, 2023
…inned column

Change the order of conditionals to remove blank space between the last
unpinned column and the pinned right column in order to fix the
availableWidth behavior

This commit fixes #4949 (pull #6284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants