Skip to content

The dummy column created when grouping adds a redundant watch #816

Closed
@nikospara

Description

@nikospara

This is an enhancement request.

When grouping (showGroupPanel: true), a dummy column is inserted at the start of each grid row. This is always empty and acts as a placeholder under the group expansion triangle. This column, inserted in rowFactory.getGrouping, uses the standard cell template defined here.

The empty field of the grouping column is substituted in ng-cell.js:

var cellTemplate = $scope.col.cellTemplate.replace(COL_FIELD, 'row.entity.' + $scope.col.field);

This will place a watch for the expression row.entity. (note the final dot, related to this bug). This watch is redundant since there will never be any data in this cell.

Proposed solution

Modify rowFactory.js, presently line 231, to define a simple template for the grouping column, e.g.:

// Line 231:
cellTemplate: "<div class=\"ngCellText\" ng-class=\"col.colIndex()\"></div>"

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions