Fix #1685: Remove col.index from most code #1692
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed col.index everywhere it appears, except for in the cell content templates, which appear to use col.index in creating the cell class. Added a column renumber to buildColumns to always give every column an index starting at zero.
|
Replaced by #1705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed col.index everywhere it appears, except for in the cell content
templates, which appear to use col.index in creating the cell class.
Added a column renumber to buildColumns to always give every column an
index starting at zero.
Reviewed every tutorial to see if there was breakage. Found breakage, but only one item that related to this change (the rest was pre-existing).
One outstanding defect that I couldn't resolve (nor see how this change caused it, although it clearly did) is that tutorial 113 - adding and removing columns - doesn't correctly splice a new column in the middle. The data turns up, but the header widths appear to be slightly off, and therefore everything is wrapping. Upon scrolling the data fixes itself, the headers don't.
Looking for a review and suggestions on what could be causing that, rather than expecting this to be merged.