Fix(importer): changes to handling of data watch #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a dataChangeCallback capability to grid, which is called by the data watch function. Make use of this for importer to know when the data change has occurred. Refer angular-ui#1819 for the concept here. Fix rowEdit so that error rows aren't duplicate entered into rowEditRowsDirty if they error twice. Update tutorial numbering - newer tutorials have conflicted with older. Change importer to require an explicit callback to be provided by the user - change the data from userspace rather than in the grid itself. Fix grid menu so that it displays correctly on Chrome, it had started only partially rendering. Fixed by changing position from absolute to fixed.
PaulL1
added a commit
that referenced
this pull request
Oct 15, 2014
Fix(importer): changes to handling of data watch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dataChangeCallback capability to grid, which is called
by the data watch function. Make use of this for importer to
know when the data change has occurred. Refer #1819 for the
concept here.
Fix rowEdit so that error rows aren't duplicate entered into
rowEditRowsDirty if they error twice.
Update tutorial numbering - newer tutorials have conflicted with
older.
Change importer to require an explicit callback to be provided
by the user - change the data from userspace rather than in the
grid itself.
Fix grid menu so that it displays correctly on Chrome, it had
started only partially rendering. Fixed by changing position from
absolute to fixed.