Fix #1792(options): use gridOptions rather than copy them #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current arrangement is to shallow copy gridOptions, which means changes to scalar values are not automatically noticed. Change to reference gridOptions directly, defaulting any necessary values over the top. This then allows options to be referenced and updated dynamically.
|
Not merging this, requires review by @c0bra and/or @swalters. Not clear to me whether a deliberate decision was taken not to reference options and to copy them instead, this could be a substantial change with implications I don't understand. All unit and e2e tests pass, but that doesn't mean something obscure won't be broken. |
PaulL1
added a commit
that referenced
this pull request
Oct 23, 2014
Fix #1792(options): use gridOptions rather than copy them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current arrangement is to shallow copy gridOptions, which
means changes to scalar values are not automatically noticed.
Change to reference gridOptions directly, defaulting any necessary
values over the top. This then allows options to be referenced
and updated dynamically.