Release 2.0.5 #358
Merged
Release 2.0.5 #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: test/karma.conf.js
getTemplate() now return a promise. It is immediately resolved if the template is local. If it is remote, the promise is resolved after the template is fetched and put into the cache. Also the $http request is cached in $templateCache as well, so the same template should only be fetched once no matter now many grids use it. New function self.initTemplates(), calls getTemplate() for each of the template types. Returns a promise via $q.all() that bundles all the getTemplate() promises. self.init() now returns a promise and defers execution until after initTemplates() completes.
grid.init() is now called here, not in src/classes/grid.js. It returns a promise which delays the execution until everything is ready (templates, and whatever else init() does).
A bug with external templating occurs when the template comes back AFTER the data is ready to be drawn in the grid. This script uses express to delay serving the grid template for a couple hundred milliseconds.
There is a bug with external templating where if the template comes back AFTER asynchronously loaded data is ready, an "$apply/$digest is already executing" error will occur. This test will demonstrate that in tag 2.0.4 if you access it via scripts/server.js Conflicts: workbench/templating/external.html
sortActual() was using a non-existent variable for accessing the row in rowCache while iterating over the data.
|
i think we can go ahead and release this |
ghost
assigned 
|
Please include #369, thanks |
c0bra
added a commit
that referenced
this pull request
Apr 29, 2013
Release version 2.0.5. Changes are in README.md
|
@molocco further changes will be going into 2.0.6. Thanks for the PR, though! It would be great to have a unit test for this, but I will try to create one if you can't/don't have time. |
|
@c0bra Bower needs a corresponding tag for this release before bower-users are able to pull it. |
|
@Siyfion oops, try it now please. |
|
@c0bra Much better... 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for 2.0.5 release.
This includes fixes for #348, #347.
Please provide any feedback here.