Skip to content

fix(col-movable): prevent hidden columns triggering unnecessary re-or… #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 22, 2016
Merged

fix(col-movable): prevent hidden columns triggering unnecessary re-or… #5255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/features/move-columns/js/column-movable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,23 @@
});
},
redrawColumnAtPosition: function (grid, originalPosition, newPosition) {
var columns = grid.columns;

if (originalPosition === newPosition) {
return;
}

var columns = grid.columns;
//check columns in between move-range to make sure they are visible columns
var i0 = Math.min(originalPosition, newPosition);
for (i0; i0 < Math.max(originalPosition, newPosition);i0++) {
if (columns[i0].visible) {
break;
}
}
if (i0 === Math.max(originalPosition, newPosition)) {
//no visible column found, column did not visibly move
return;
}

var originalColumn = columns[originalPosition];
if (originalColumn.colDef.enableColumnMoving) {
Expand Down