fix: prevent hidden columns triggering unnecessary re-order #5522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 30, 2016 07:17
fix: update bower.json and package.json to include files for current npm chore: Release v3.2.4 chore: Release v3.2.5 fix: update bower.json and package.json to include files for current npm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix checks all the columns between the originalPosition and newPosition. IF they are all hidden, then no re-order event is necessary. If a visible column is found, column re-ordering will be triggered. This is an adjustment of #5255 as originalPosition is always a visible column.
Fixes issue: #5254