fix(Grid Scrolling): Overwriting default scrolling for better UX. #5840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return correct order when only one member has priority.
Add mousedown listener to ui.grid.edit.directive:uiGridEditor to disable blur handler if the element is a checkbox, and then re-focus the checkbox and enable the blur handler after a $timeout. This change is to deal with Safari and Firefox behavior in macOS where clicking the checkbox causes a blur event, and the value is not updated. GitHub issues: #1785, #4778, #4782
* Option to adjust where the exporter showed up in the menu I added a new option exporterMenuItemOrder for the gridOptions so that I could adjust where the menu items were showing up in the grid * adding option to adjust grid menu item order adding to the tests to make sure when set to default number and when set to non default number the option still works
Making as many of the code review changes as possible, renaming some variables and adding documentation.
Minor refactoring and moving constants to a more appropiate location.
Creating a new function to calculate the x and y moves in the move function.
Replacing instances of window and document with and . Also, added annotations and updated constants name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a wrapper service that takes over the default scrolling logic in order to ensure that grid scrolling works consistently in both the browser and devices, as well as slow machines.
#1689, #3719