Angular 1.6 "Possibly unhandled rejection: canceled" fix. bug number #5890 #5949
Conversation
|
What is the bug number? |
| rowHeader.colDef.visible = newVisibility; | ||
| grid.queueGridRefresh(); | ||
| if ( rowHeader ) { | ||
| if ( rowHeader.visible !== newVisibility ) { |
There was a problem hiding this comment.
why not do a single if statement?
if ( rowHeader && rowHeader.visible !== newVisibility ) {
There was a problem hiding this comment.
i will update to single if statement
dominusbelial
changed the title
|
is this pull request going to be accepted? would obviously prefer to stay on the main code base! |
|
@goleafs Are you using this branch? If you've tested this let us know and it's more likely to be merged |
|
I made the same changes locally, have used it for a few days with no issues. |
|
@goleafs We will merge this. Unfortunately, we are currently busy with our day jobs right now, so we had to stop working on Ui-grid for a bit. We also are having a weird issue with the travis build. Once the travis build issue is resolved, we will see if we can get around to all of the open PRs. I am sorry for the inconvenience. |
|
+1 |
1 similar comment
|
+1 |
|
Really waiting for it... :) This is the last think that block us to switch to Angular1.6... |
|
+1 |
1 similar comment
|
+1 |
using sebastian-zarzycki-es solution i have added ".catch(angular.noop)" to all the offending promises on the latest 4.0.2 uigrid for angular 1.6.1