fix #5760: only show ui-grid-scrollbar-placeholder if there's a horizontal scrollbar in another container

[jeffantosh]

Basically adding a check to see if the sum of all of the widths containers in the grid exceeds the viewport size. If true and if horizontal scrolling is not disabled, then show the ui-grid-scrollbar-placeholder div.

[mportuga]

Could you add some unit tests to cover all possible scenarios for this? I want to make sure that no one breaks this function in the future.

[jeffantosh]

I don't know enough about the inner workings of ui grid to make these unit tests work. I also was unable to get the unit tests to even execute on my machine.

PhantomJS 2.1.1 (Linux 0.0.0) GridRenderContainer factory needsHScrollbarPlaceholder should return false if the container does not have the horizontal scrollbar enabled FAILED
Expected 0 to be false.
/home/travis/build/angular-ui/ui-grid/test/unit/core/factories/GridRenderContainer.spec.js:242:53
PhantomJS 2.1.1 (Linux 0.0.0) GridRenderContainer factory needsHScrollbarPlaceholder should return true if another container does have a horizontal scrollbar and the current container does not have the horizontal scrollbar enabled AND the total canvas width is greater than the grid width FAILED
Expected false to be true.
/home/travis/build/angular-ui/ui-grid/test/unit/core/factories/GridRenderContainer.spec.js:246:53

[mportuga]

Closing since we are unable to fix the unit tests at this time.

[piller187]

Just wondering what's the deal with this issue as it's still an issue it seems.