Directive to search parent for leaflet directive

[eugenehuangsg]

I'm experimenting with separation of concerns using nested components within the leaflet directive. And I was thinking there is no real limitation on why we shouldn't allow ui-leaflet-draw to still work within the nested components. Is this okay?

[nmccready]

Build dist and lets talk about this.

[nmccready]

https://docs.angularjs.org/guide/directive#creating-directives-that-communicate

The ^^ prefix means that this directive searches for the controller on its parents. (A ^ prefix would make the directive look for the controller on its own element or its parents; without any prefix, the directive would look on its own element only.)

So if this makes it work only by searching on it's parent then I am opposed (can be swayed). If it can work with both then I see no issue.

This is actually interesting because in reality I think this directive only depends on leaflet directive to get its relative map being loaded .

Anyway, if we move this to nesting I guess this would be a minor change or major? What do you think?

On breaking paradigm shift is making this nested as every attribute in ui-leaflet 1.X is on the same directive element.

Anyway, if travis didn't build the dist file this PR will need to do so. As I want to see if it still passes .

[eugenehuangsg]

@nmccready Yes, i absolutely agree that it should work for both parent and on its own element. (Should not break any existing paradigm). It was my oversight that read '^^' wrongly from the documentation. I have since changed it to only '^' and built dist using gulp. Thanks for pointing out the documentation clearly.

This is actually interesting because in reality I think this directive only depends on leaflet directive to get its relative map being loaded .

Yes, i think its very interesting too. So as long as this draw directive can find the leaflet's controller, everything should work as designed.

[eugenehuangsg]

@nmccready Is this okay?

[nmccready]

If we do this then we will need to bump the minor or major. Also from this main leaflets directive's standpoint all the directives share the same scope. So this is a break from the original design. Anyway, neither this or the other project is very active anymore. So I can be swayed either way.