-
Notifications
You must be signed in to change notification settings - Fork 46
Issue40 fix crush #41
Conversation
public renderElement method
# Conflicts: # src/mentionController.es6.js
|
Thanks for fixing this! I noticed there are other places that may throw an error on a bad choice selection. Namely EDIT: Disregard this comment, I've tested your changes and they seem to have fixed the problems I had mentioned as well. Thanks Again @biggieman |
example/example.js
Outdated
| message: 'hi there @k' | ||
| }; | ||
| }).directive('mentionExample', function () { | ||
| }]).directive('mentionExample', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's not necessary for example, but on original gulpfile.js task scripts:example pipes ngAnnotate (like main scripts)
ProLoser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the modification to the example file is necessary. If you remove it I'll merge in this change.
|
Along with #35 I prefer NOT to use the more explicit injection syntax because that should be handled by a preprocessor so that the source code can be minimal. Additionally, the minified version of the example does NOT rename the variable, voiding the need for this injection syntax. Finally, there's no reason for anyone to re-process the example file itself since it's only an example. |
|
@ProLoser: remove annotates from this pull and #35 |
#40 I think only one place need fix.