Angular 1.4, ngAnimate 1.4 and ui-router…

[hadrienl]

…doesn't work… I have en error from angular-animate : "Cannot read property '' of undefined"
Downgrade to 1.3 and everything works fine.

[nateabele]

Okay. Please post a plunkr with your setup and I'll take a look. Thanks for the report.

[ben-hart]

+1 - I am also experiencing issues with the same versions: (1.4.0-rc.0) Angular 1.4 + ngAnimate 1.4 + ui-router 0.2.13.

[Rush]

I am not getting any errors but my state animations stopped working with Angular 1.4 + ui-router.

[levbrie]

+1

[nateabele]

Okay, if anybody wants to set up a plunkr, I'll take a look and see if I can debug it.

[levbrie]

I just set up a plunkr with 1.4.0-rc.1 and it seemed to be working fine, so I updated to 1.4.0-rc.1 in my own code base and that seemed to fix the issue there as well:

http://plnkr.co/edit/gRkr78?p=preview

[nateabele]

Nice. Can other people confirm the same?

[Rush]

Yes, rc1 fixed it for me!

[levbrie]

Just as a sidenote, the actual animating of the photos in my plunkr doesn't work as expected, either in the ui-router version I provided (http://plnkr.co/edit/gRkr78?p=preview) or in the ngRoute version I based it off of (http://plnkr.co/edit/OF2snm?p=info), which was meant to be an exact copy of http://slides.yearofmoo.com/ng-conf-2015/demos/anchor-views/index.html, which Matias presented at ng-conf. So either something changed in the new release or I'm missing something in the code. Any suggestions would be much appreciated (the transition between pages works, but the chosen photo does not animate as it should).

[ben-hart]

rc.1 did not fix my routing issues. I have an app working perfectly fine in 1.4.0-rc.1 with latest ui-router w/o ngAnimate loaded. Adding ngAnimate (same for both rc.0 or rc.1) eventually causes issues with routing. At first everything works fine, then after running through an inconsistent number of routes (different each reload), routing will suddenly stop working - url bar shows changing locations but pages do not load. no errors shown.

[nateabele]

So either something changed in the new release

Probably that.

[neaped]

angular 1.4.rc.1 doenst fix my routing as well.

In my side, the console give following error:

TypeError: Cannot read property 'end' of undefined
    at angular-animate.js:2207
    at forEach (angular.js:332)
    at closeChildAnimations (angular-animate.js:2202)
    at queueAnimation (angular-animate.js:2048)
    at Object.$$AnimateQueueProvider.$get.push (angular-animate.js:1943)
    at Object.$AnimateProvider.$get.leave (angular.js:5126)
    at Object.leave (angular-ui-router.js:3859)
    at cleanupLastView (angular-ui-router.js:3910)
    at angular-ui-router.js:3938
    at publicLinkFn (angular.js:7308)

Dig into the source code in ngAnimate 1.4, it refactor the leave function, so the getRenderer function within ui-router should be modify (am i right?)

Further more, look into the html page, the previous DOM element didn't remove correctly, but the ui-router will keep add a new DOM element on it.

Any idea?

[nateabele]

@neaped If you patched it locally, paste your diff here and I'll check it out.

[neaped]

@nateabele In ngAnimate 1.4.0 rc1 Line 2202

 switch (state) {
          case RUNNING_STATE:
                console.log('break')
            //animationDetails.runner.end();

I just remove the line 2205, the problem became solved. It didn't look like the problem with the new leave function. Look back on line 2201

var animationDetails = activeAnimationsLookup.get(child);

the activeAnimationsLookup is came from $$HashMap Service in line 1825

var activeAnimationsLookup = new $$HashMap();

But dig into angular's (1.4 rc1) source code, I am not able to trace the problem further more, any idea how I can keep tracing this problem? I'm still a newbie xD

[nateabele]

@neaped Ah, I misunderstood. I thought you patched UI-Router. Anyway, I think this might be related to another bug (don't have the # handy right now), but I'll try patching it later today and pushing a new point release, and we'll see if it addresses this as well.

[neaped]

@nateabele Not misunderstood, just my fault. Coz I was trying to patch UI-Router, but at the end, I make it work by patched the ngAnimate xD

I wasn't really sure whether it's a bug or just something wrong with the refactored function. In addition, I just don't know where/how to trace the problem further.

[shprink]

I had the same problem because angular-animate was @1.3.15. Upgraded it to 1.4.0.rc-1 and it works fine. It is not a ui router issue.

[pisaacs]

+1 with 1.4 rc1... just upgraded and ran into the same issue.

TypeError: Cannot read property 'end' of undefined
    at angular-animate.js:2204
    at n (angular.js:332)
    at H (angular-animate.js:2199)
    at L (angular-animate.js:2044)
    at Object.t.module.directive.factory.factory.provider.$get.push (angular-animate.js:1939)
    at Object.Me.$get.leave (angular.js:5126)
    at Object.leave (angular-ui-router.js?body=1:3860)
    at cleanupLastView (angular-ui-router.js?body=1:3911)
    at angular-ui-router.js?body=1:3939
    at angular.js:7308

[pisaacs]

1.4.0-beta.6 works. However, the next version 1.4.0 rc0 doesn't work, and there are breaking changes with $animate. See https://github.com/angular/angular.js/blob/master/CHANGELOG.md for more details

[MikaAK]

@pisaacs This is a known issue with angular 1.4. There is a PR open with a fix
See here

[zakhenry]

The issue @MikaAK referenced above has been closed and is now in 1.4.0 angular/angular.js#11760

[nateabele]

So, we can close this?

[MikaAK]

Yes this can be closed!

[samypr100]

I'm still experiencing a similar issue. See angular/angular.js#13215