Animations with Angular 1.2.0rc1

[lanceschi]

Hi,

it seems animations don't work at all with the new release of Angular 1.2.0rc1. Most probably a fix is needed.

Great job btw.

Cheers,
Luca

[bcronje]

Yes it seems the ngAnimate API changed, see http://www.yearofmoo.com/2013/08/remastered-animation-in-angularjs-1-2.html for the rundown. Hopefully someone on the ui-router team will pick this up, as it should be a core functionality of any ui route implementation in my opinion.

[timkindberg]

Of course we will. As soon as its in a stable release.

[lanceschi]

Btw with Angular 1.2.0rc1 additional core modules now are to be specified:
angular.module("unnamedApp", ['ngRoute', 'ngAnimate' ...

Cheers,
Luca

[nateabele]

@timkindberg Maybe we can put this on a angular-1.2 branch or something.

[timkindberg]

Good idea

[rlrosa]

this is pretty nice http://www.yearofmoo.com/2013/08/remastered-animation-in-angularjs-1-2.html#how-to-make-animations-in-angularjs

[nateabele]

Okay, I've created an angular-1.2 branch which contains a refactored uiView directive and updated tests. However, 3 tests are still failing for reasons I haven't been able to figure out.

If you're using Angular 1.2 for development, I would encourage you to check out and build from the branch, help test the changes, and help debug the failing tests. Thanks.

[bcronje]

Nate, first bug:

The second parameter to $animate.leave() is a callback, you currently have it set to element.

Should be changed to

remove: function(element) { $animate.leave(element.contents()); },

Doesn't do anything for the failing tests though.

[bcronje]

Nate, I played around with this branch over the weekend and found a few issues.
Then new enter(element, parent, after, done) animation method actually applies the animation classes to element and not parent, so with your current implementation you have to wrap your template code for the animations to work as intended which is not ideal.

I'll send a PR later today that might be a step in the right direction.

Question, is the ability to render the default content inside a ui-view that does not have a template a requirement? Or can any static content inside ui-view be discarded?

[nateabele]

Question, is the ability to render the default content inside a ui-view that does not have a template a requirement?

Yes. It should be present whenever there's nothing else to render.