Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing EOL in package.json @ 1.0.9 breaks artifactory npm plugin #3550

Closed
1 of 3 tasks
RecuencoJones opened this issue Oct 18, 2017 · 3 comments
Closed
1 of 3 tasks

Comments

@RecuencoJones
Copy link
Contributor

RecuencoJones commented Oct 18, 2017

This is a:

  • Bug Report
  • Feature Request
  • General Query

My version of UI-Router is: 1.0.9

Bug Report

Current Behavior:

Install from artifactory npm plugin fails.

Expected Behavior:

Installs correctly in v1.0.9

Comment

Could you please add new line at the end of package.json in the next release?

It was removed in 1.0.9 release and it might be causing this issue.

@nateabele
Copy link
Contributor

This is a reasonable change to make (especially if you'd like to submit a PR), but if you want to consider this a bug, it's a bug in Artifactory.

RecuencoJones added a commit to RecuencoJones/ui-router that referenced this issue Oct 18, 2017
@RecuencoJones
Copy link
Contributor Author

@nateabele you are right, we are confused by the fact that this has never happened before with any other package, and probably not every package.json ends with new line.

It might be a problem with artifactory indeed, I will try to file an issue there too.

@christopherthielen
Copy link
Contributor

Released 1.0.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants