Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE performance issue #149

Closed
zsolttsz opened this issue Mar 17, 2017 · 2 comments
Closed

IE performance issue #149

zsolttsz opened this issue Mar 17, 2017 · 2 comments

Comments

@zsolttsz
Copy link

zsolttsz commented Mar 17, 2017

I'm getting some weird behavior when scrolling on IE. Compared to Chrome, it renders more (unnecessary) DOM elements (plunker example: https://plnkr.co/edit/8CGpeXtXbioFPx76AHl0?p=preview). This becomes a real bottleneck when the grid has a lot of rows with some additional watchers (from ng-change, ng-class, etc.)

Looking at the top visible element, on IE there are ~200 rows before the first visible element when scrolled to EOF (in the plunker example the topVisiblie element is shifted a bit on chrome as well, but in the project I'm working on, it shows the correct elemet). The DOM Explorer confrms this.

Also it seems that after EOF is reached on IE, when scrolling back to the top, after a while the scroll becomes jumpy (something similar to this: #100). In prod, I'm having this same issue, with the difference that EOF doesn't need to be reached first; after ~70 rows it kicks in.

Any ideas/guidelines are welcome.

@dhilt
Copy link
Member

dhilt commented Apr 9, 2017

@zsolttsz This is not a performance issue, this is a true bug. Thanks for the report and repro. I've made a fix and forked your plunker: https://plnkr.co/edit/hU3yztEn39YwqxpkbghY (the ui-scroll distributive was overrided, this is the only change I did). So the fix is in 'master' branch and will be included in the next (v1.6.2) release.

@zsolttsz
Copy link
Author

Thanks for looking into the issue, and for the plunker. It helps a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants