You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not a serious error... but it bind and unbind are deprecated.
You won't have a problem if using jqlite, because in AngularJS, JQLite.prototype.bind = JQLite.prototype.on; and JQLite.prototype.unbind = JQLite.prototype.off;
But if you load JQuery 3.51 and the unminified jquery-migrate.js you will get logs about usage of deprecated functionality.
I made little research. The on/off methods appeared in jQuery 1.7 in 2011 and in AngularJS 1.2 in 2013. The angular-ui-scroll does not support AngularJS less than 1.2. So the change you proposed seems reasonable and will not affect any of the lib users. I switched base branch of your PR as I'm going to make some additional work. Thanks for your contribution!
This is not a serious error... but it
bind
andunbind
are deprecated.You won't have a problem if using jqlite, because in AngularJS,
JQLite.prototype.bind = JQLite.prototype.on;
andJQLite.prototype.unbind = JQLite.prototype.off;
But if you load JQuery 3.51 and the unminified
jquery-migrate.js
you will get logs about usage of deprecated functionality.ui-scroll/src/ui-scroll.js
Lines 246 to 247 in a957d07
ui-scroll/src/ui-scroll.js
Line 230 in a957d07
ui-scroll/src/ui-scroll.js
Line 230 in a957d07
The above cases of
bind()
andunbind()
should beon()
andoff()
respectively.The text was updated successfully, but these errors were encountered: