Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

0.9.6 + angular 1.3.11 error #652

Closed
btm1 opened this issue Feb 12, 2015 · 7 comments
Closed

0.9.6 + angular 1.3.11 error #652

btm1 opened this issue Feb 12, 2015 · 7 comments

Comments

@btm1
Copy link

btm1 commented Feb 12, 2015

Your examples use 1.3.0 of angularjs but as soon as you update the version to 1.3.11 and you look at the tagging example there is an issue. the tagging seems to sort of work:

The key bindings for tagging tokens don't work anymore so you type ',' or ENTER and it doesn't auto tag.
Also even if you hit return and select the tag it keeps the written text in the input field afterwards at the end of the tags.

@btm1
Copy link
Author

btm1 commented Feb 13, 2015

any movement on this? If i knew the library better i'd just crawl in there and fix it myself.

@octavioamu
Copy link

@octavioamu
Copy link

@btm1 try to write 'reset-search-input' without quotes in the directive

http://plnkr.co/edit/SvnCvTgiJSYJuuQehA7m?p=preview

@btm1
Copy link
Author

btm1 commented Feb 23, 2015

reset-search-input works but i'm guess that's just a temporary fix until that bug is resolved?

@octavioamu
Copy link

I don't think is a fix because is working with angular 1.3.0 Is a bug introduced with angular 1.3.1 and in the code the option 'reset-search-input' is undefined. Have not ideia why and how in 1.3.0 is true.

@btm1
Copy link
Author

btm1 commented Feb 24, 2015

yeah i'm not sure all i know is this fixes my issue for now though. But I'm guessing that there needs to be revisited.

radharamana added a commit to radharamana/ui-select that referenced this issue Feb 25, 2015
Angular 1.3 doesn't seem to handle defaulting attributes in the same way not sure what else this affects
@dimirc
Copy link
Contributor

dimirc commented Feb 26, 2015

Should be fix now with #703

@dimirc dimirc closed this as completed Feb 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants