This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Configure skip focusser #1487
Merged
Configure skip focusser #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no easy way to configure if the focusser should be skipped after selecting an item. The fact that the focusser is always focused after selecting an item is especially problematic on mobile devices, since this leads to the keyboard being shown, which might not be desirable. This commit provides the skip-focusser option to configure this behavior on the ui-select directive. Fixes #869, #401, #818, #603, #432 (partially)
|
@excentris Can you please update the wiki to document this new option? |
|
@aaronroberson Done! Thank you very much for merging this! |
|
You're welcome. We try to stay away from adding too many options, supporting every possible feature and configuration because it can become kludgy and even more difficult to manage. However, enough people have needed this feature that I let it through ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new feature to be able to configure skipping the focusser after selecting an item.
After much trying I have unfortunately not found a way to cover the changes with the necessary unit tests. Focusing and testing the involved elements for focus proved more complex than I thought...