This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Fix is disabled and prevent modifying items #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the item from the list was modified with the _uiSelectChoiceDisabled property. This allowed a leakage of information from ui-select to outside the directive. It also caused issues when the was used outside of the directive. This commit adds a reference array to store disabled items and so prevents the need to modify the item in place. Closes angular-ui#1200 and angular-ui#1661 Partially supersedes angular-ui#1641
Resolves issue where isDisabled was running for tags and causing a infite loop to occur if the new tag value included a previous value. For example: tag1: "a" tag2: "aa" Fixes angular-ui#1693
Previously setting a selected item as locked modified that item, this could cause issues if the item was used outside of the directive. This commit changes the directive to store the information internally thus preventing it from interfering with external uses. Closes angular-ui#1269 and angular-ui#514 Supersedes (and closes) angular-ui#1641 and angular-ui#952
user378230
force-pushed
the
fix-is-disabled
branch
from
2160208 to
c01d363
Compare
This was referenced Jul 9, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors isDisabled and isLocked to no longer rely on modifying the list item with
_uiSelectChoiceDisabledand_uiSelectChoiceLockedproperties which caused issues when items were used elsewhere (outside of theui-selectdirective).Also, resolves infinite digest loop caused by attempting to add a new tag that included an existing tag, ie:
Closes #1200, #1661, #1693, #1269, #514
Closes #1641 and #952 (supersedes)