This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Adding support for non existing values (allow free text) in single select #1924
Open
afro1114
wants to merge
2
commits into
angular-ui:master
Choose a base branch
from
afro1114:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HI @afro1114 , Thanks for the PR but for now we don't do any new features as there are many bugs. Hope you understand the situation and maybe you can assist in other bugs. Thanks. |
Looks like I made a mistake. I will reopen it and have a look at it. @nickiowaspain It is not fixed for now. @afro1114 could you clean up the commit? (remove the |
Hi @Jefiozie in this case what is the tag needs:work referring to? |
Hi, What kind of works is needed to merge this request. I really need this feature currently and don't want to use a fork ? So if i can help but don't know where to start |
Any progress on this issue? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses most of the code already existing for tagging in multiple selection, however it uses a different attribute because there are parts of the code that are not shared and only apply to single selection.
Using the feature is done in the same way tagging does:
allow-free="transformFunction"