Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Adding support for non existing values (allow free text) in single select #1924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

afro1114
Copy link

This uses most of the code already existing for tagging in multiple selection, however it uses a different attribute because there are parts of the code that are not shared and only apply to single selection.

Using the feature is done in the same way tagging does:
allow-free="transformFunction"

@Jefiozie
Copy link
Contributor

HI @afro1114 ,

Thanks for the PR but for now we don't do any new features as there are many bugs.
Next to this I should refer you to the CONTRIBUTING.MD you have a lot of file changes as you didn't clean up everything.

Hope you understand the situation and maybe you can assist in other bugs.

Thanks.

@Jefiozie Jefiozie closed this Feb 23, 2017
@afro1114
Copy link
Author

afro1114 commented Feb 23, 2017

Well @Jefiozie there is actually a bug regarding this topic #1409

@nickiowaspain
Copy link

So wait @Jefiozie and @afro1114. Has this been fixed. I am also running into this problem.

@Jefiozie Jefiozie self-requested a review March 21, 2017 05:32
@Jefiozie
Copy link
Contributor

Jefiozie commented Mar 21, 2017

Looks like I made a mistake. I will reopen it and have a look at it. @nickiowaspain It is not fixed for now.

@afro1114 could you clean up the commit? (remove the select.js etc.)

@Jefiozie Jefiozie reopened this Mar 21, 2017
@Jefiozie Jefiozie removed their request for review March 21, 2017 07:01
@afro1114
Copy link
Author

Hi @Jefiozie in this case what is the tag needs:work referring to?

@Jefiozie
Copy link
Contributor

Hi @afro1114 the cleaning up part as in my previous comment addressed comment

@MathRobin
Copy link

Hi,

What kind of works is needed to merge this request. I really need this feature currently and don't want to use a fork ? So if i can help but don't know where to start

@brunosantosnasajon
Copy link

Any progress on this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants