Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Tagging support #63

Closed
wants to merge 10 commits into from
Closed

Tagging support #63

wants to merge 10 commits into from

Conversation

malexandre
Copy link

Based on the pull-request of @tandibar #38, I renamed the "add-new-value" to "tagging", and added the management of a function for the tagging attribute.

The tagging can be enabled by adding the attribute "tagging". If set to "true", the search term will be used as the new item. If set to a funciton, the search term will be pass in attribute to the function. For example, I use a function to build a new object from the search term that is like the other objects managed by my ui-select.

@tandibar
Copy link

Cool, thx for merging!

@steffenmllr
Copy link

+1 Any Chance of this getting merged?

@juanpujol
Copy link

+1

@brycejacobs
Copy link

+1 Any eta?

@yaru22
Copy link

yaru22 commented Jul 9, 2014

+1. Any update on this?

@dainnilsson
Copy link

+1

@dimirc
Copy link
Contributor

dimirc commented Aug 4, 2014

@malexandre can you rebase this?

@malexandre
Copy link
Author

I'll do that later today or tomorrow.

@elgerlambert
Copy link

Great addition! Was about to try and realise this type of behaviour myself. Looking forward to this PR landing! +1

@brettstack
Copy link

+1

@sagar-ranglani
Copy link

+1. ETA?

@pwchan
Copy link

pwchan commented Sep 18, 2014

+1. Any ETA?

@parliament718
Copy link

I can't seem to get this working in 0.7 branch, it's too out of sync already. Can someone please merge this it's much needed feature.

@sagar-ranglani
Copy link

Yeah!!! Can we bring it to v0.8 ... as @parliament718 said, It's a much needed feature.

@tvervest
Copy link
Contributor

tvervest commented Oct 5, 2014

Bad news: I really need this feature for a project I'm working on.
Good news: I'm going to make some time tomorrow to try and apply/re-create the patch on the current master.
So in other words, with a bit of luck I'll have a new pull request ready tomorrow which can be merged direct into the current master. I'll keep you guys posted!

tvervest added a commit to tvervest/ui-select that referenced this pull request Oct 6, 2014
@tvervest tvervest mentioned this pull request Oct 6, 2014
@tvervest
Copy link
Contributor

tvervest commented Oct 6, 2014

I've created pull request #260 in which I've re-applied the changes included in this pull request.

@dimirc
Copy link
Contributor

dimirc commented Oct 10, 2014

Let's continue the discussion of this feature at #260

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.