This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Prevent whole page scroll when scrolling ui-choices #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 18, 2015 13:24
Prevent the anoying default browser behavior of scrolling the whole page when scrolling in ui-choices options, usefull when it has lots of options, and changeble in uiSelectConfig and preventPageScroll attr.
default value for preventPageScroll config option.
src/uiSelectChoicesDirective.js
Outdated
| @@ -47,6 +47,18 @@ uis.directive('uiSelectChoices', | |||
| if (rowsInner.length !== 1) throw uiSelectMinErr('rows', "Expected 1 .ui-select-choices-row-inner but got '{0}'.", rowsInner.length); | |||
| rowsInner.attr('uis-transclude-append', ''); //Adding uisTranscludeAppend directive to row element after choices element has ngRepeat | |||
|
|
|||
| if ($select.preventPageScroll) {// Prevent the whole page for scrolling when the choices ul reaches it's scroll limits. | |||
| element.bind('mousewheel', function(event) { | |||
|
While this was not merged, I used this code in an angular directive that applies by the class name of the dropdown list container, and it helped me a lot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the browser's annoying default behavior of scroll the whole page
when scrolling in ui-choices options, useful when it has many
options, changeable in uiSelectConfig globals and preventPageScroll attribute.