Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Do not run bower after install automatically #982

Merged
merged 1 commit into from
Jul 31, 2015

Conversation

vperron
Copy link
Contributor

@vperron vperron commented Jun 2, 2015

This should be an user action, not something automatically run on install.
We're using ui-select in a browserify project, and we don't need/have bower installed. Furthermore it pollutes the development folder with an unused bower_components.

This should be an user action, not something automatically run on install.
We're using ui-select in a browserify project, and we don't need/have bower installed. Furthermore it pollutes the development folder with an unused bower_components.
@vperron
Copy link
Contributor Author

vperron commented Jun 4, 2015

If someone sees this, please tell us if merging is an option.

@k-lange
Copy link

k-lange commented Jun 30, 2015

@brianfeister can we please get this merged? If you want to keep the bower install for development purposes you can add it to prepublish, then it's installed when you do a local npm install.

@vperron
Copy link
Contributor Author

vperron commented Jun 30, 2015

Not even k-lange... NPM should not rely on bower, it's a malpractice on the long term ! As if apt-get was relying on yum or pacman...

@vperron
Copy link
Contributor Author

vperron commented Jul 28, 2015

Please please please can you finally merge that one ???

@visnup
Copy link

visnup commented Jul 31, 2015

+10

dimirc added a commit that referenced this pull request Jul 31, 2015
Do not run bower after install automatically
@dimirc dimirc merged commit 271bf6a into angular-ui:master Jul 31, 2015
@visnup
Copy link

visnup commented Jul 31, 2015

💖

@vperron
Copy link
Contributor Author

vperron commented Jul 31, 2015

PRAISE THA LORD

@shlensky
Copy link

shlensky commented Nov 6, 2015

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants