This repository was archived by the owner on Sep 8, 2020. It is now read-only.
Fix for auto sorting items in select element #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with select2 that if i had some optgroups and items in it and if i selected 1 item from the second and 1 item from the first, the second item was moved to first position.
I found in angular.js:
that model is being filled by iterating the selected options in select element. So if we do this in ui-select2:
We actually update the element with model values and "resort" all items by the model. This is not a good approach I think.
I made a fix for it so the render will hit select element once (items get sorted at the beginning by model) and then after selecting options only model gets updated and items will be added. But they wont sync and user wont be confused by item getting away by sorting.
Also link to already reported issue #12
EDIT: i see it doesnt make through tests. If there is someone who can fix it properly it would be very helpful. I have no time for this at the moment.