Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Using ui.sortable with angular ui.bootstrap.tabs have a weird interaction #248

Open
hghammoud opened this issue Aug 17, 2014 · 3 comments
Open

Comments

@hghammoud
Copy link

If you look at the following plunker http://plnkr.co/edit/0qeS4x?p=preview

if we place tabs inside tabset you will see that the drag moves all of the tabs heading not just the one selected.
If you seperate them like in version 2 on the same plunker it works. Is there something i am doing wrong or is it a bug/missing feature?

TY

@thgreasi
Copy link
Contributor

My attempt showed that the tabset directive transcludes a <div> (on which the ui-sortable is applied) and nests a <ul>.
screenshot from 2014-08-17 23 07 33

ui-sortable directive expects to be applied on the exact parent of the list. That looks like to be the cause of problem.
Take a look at #162, you might find the proposed solution simpler/lighter.

@hghammoud
Copy link
Author

That is what is shown in the plunker and what I ended up implementing but the code would have been cleaner if the plugins interacts well with each other!

Do you have an idea how we can fix this ?

@thgreasi
Copy link
Contributor

This directive needs to be applied on the parent of the draggable elements and that makes it difficult to work nice with other directives that do transcludes.
I will try to create a custom option, so that the developer can provide a CSS selector to target the resulting transcluded element.
The option name might look like ui-target-element-selector.

I will create a separate branch to work on it but:

  • don't expect it before v0.14.0
  • it might still have problems with some directives

@thgreasi thgreasi added this to the v0.14.x milestone Aug 20, 2014
@thgreasi thgreasi changed the title Using ui.sortable with angular ui.bootstrap have a weird interaction Using ui.sortable with angular ui.bootstrap.tabs have a weird interaction Oct 28, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants