Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Sortable in Table #287

Closed
Twv opened this issue Oct 23, 2014 · 2 comments
Closed

Sortable in Table #287

Twv opened this issue Oct 23, 2014 · 2 comments
Labels

Comments

@Twv
Copy link

Twv commented Oct 23, 2014

I've just forked http://codepen.io/janp/pen/AiyhD, which is working ok with divs.
I've changed the elements to be inside a table (had to do it, because the web designer wanted it... might be able to move things back to divs if I really shout a lot.... but until then).

The code seems to work, but it doesn't really - I believe the issue is with the angular comments not being left in - which is the heavy-lifting the directive does for us (I think).

http://codepen.io/janp/pen/jlaJc

Error scenario:

  • Pick G1I3 and move it to Group 2. So far, looking good, but inspecting the G1I2 shows, the last angular ng-repeat comment is now missing.
  • Click ADD ITEM button. Nothing happens.

Pressing ADD ITEM button works before moving the items.

Is using table with a normal ng-repeat supported, or is the scenario invalid from the start?
Anything I can do to fix the problem, so I can please the web designer?

@thgreasi
Copy link
Contributor

First of all,
Great Examples:registered: :+1:

As discussed in other issues about tables you should be careful when using tables, because the browser will insert a <tbody> tag anyway. As discussed in #248 and #268 (which are targeted for v0.14.x) there also some issues with the items option support.
Take a look at "my fork of your pen" (that sounds weird isn't it?).
Hope this works for you.

Once again, well presented/structured issue 👍

@Twv
Copy link
Author

Twv commented Oct 24, 2014

Thank you.
You've also made the designer happy, as he doesn't have to redo divs to behave like a table (he said it is possible, but a real PITA).
Much appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants