This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
syntax refactor #477
Open
syntax refactor #477
+77
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/sortable.js
Outdated
| @@ -20,119 +20,114 @@ angular.module('ui.sortable', []) | |||
| uiSortable: '=' | |||
| }, | |||
| link: function(scope, element, attrs, ngModel) { | |||
| 'use strict'; | |||
There was a problem hiding this comment.
I'm totally in favor of 'use strict', but this might cause errors in some ASP.Net environments.
jQuery prior v3 also didn't use 'use strict' for exactly that reason.
There was a problem hiding this comment.
Okay, I remove this line! Thanks!
|
|
||
| // update changed options | ||
| angular.forEach(newVal, function(value, key) { | ||
| // if it's a custom option of the directive, | ||
| // handle it approprietly | ||
| if (key in directiveOpts) { | ||
| if (directiveOpts[key]) { |
There was a problem hiding this comment.
That's not equivalent in case of directiveOpts members with falsy values.
|
Please don't create a hure diff. Try not moving methods until the initial refactor gets reviewed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only syntax refactor,
return null;a in bwrite inb.awill more clear;_restoreand_destroywere simplified asdelete item.sortable.