Adds appropriate types to courses.service.ts
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The course is missing the correct types for the `saveCourse` method so that tests were unable to run properly. Looks like this is fixed on the master branch but is not implemented in the 1-start branch. Changes: - Adds correct type information to saveCourse method in `course.service.ts`
|
Merged, thank you for submitting the PR, and enjoy the course. |
|
My pleasure! This course is the perfect introductory to testing Angular apps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The course is missing the correct types for the
saveCoursemethod so that tests were unable to run properly. Looks like this is fixed on the master branch but is not implemented in the 1-start branch.Changes:
course.service.ts