Skip to content

Commit

Permalink
fix(@angular-devkit/build-angular): update worker-plugin to 3.2.0 (#1…
Browse files Browse the repository at this point in the history
…5456)

includes this fix GoogleChromeLabs/worker-plugin#35 which solves the below issues.

Fixes #15188 and fixes #14582
  • Loading branch information
alan-agius4 authored and mgechev committed Aug 28, 2019
1 parent 4df025f commit 09d2f04
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 15 deletions.
2 changes: 1 addition & 1 deletion packages/angular_devkit/build_angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"webpack-sources": "1.4.3",
"webpack-subresource-integrity": "1.1.0-rc.6",
"worker-farm": "1.7.0",
"worker-plugin": "3.1.0"
"worker-plugin": "3.2.0"
},
"devDependencies": {
"@angular/animations": "~9.0.0-next.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,17 +162,8 @@ describe('Browser Builder Web Worker support', () => {

case 2:
workerContent = virtualFs.fileBufferToString(host.scopedSync().read(workerPath));
// TODO(filipesilva): Should this change? Check with Jason Miller.
// The worker changes name with each rebuild. But sometimes it also changes from 0 to
// 1 and then back to 0. It's hard to know where the updated content is, but it should
// be in one of these two.
const anotherWorkerPath = join(outputPath, '1.worker.js');
const anotherWorkerContent = virtualFs.fileBufferToString(
host.scopedSync().read(anotherWorkerPath));
// Worker content should have changed.
expect(
workerContent.includes('baz') || anotherWorkerContent.includes('baz'),
).toBeTruthy('Worker bundle did not contain updated content.');
expect(workerContent).toContain('baz');
phase = 3;
break;
}
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12279,10 +12279,10 @@ worker-farm@1.7.0, worker-farm@^1.7.0:
dependencies:
errno "~0.1.7"

worker-plugin@3.1.0:
version "3.1.0"
resolved "https://registry.yarnpkg.com/worker-plugin/-/worker-plugin-3.1.0.tgz#6311778f3514a87c273510ee3f809cc3fe161e6f"
integrity sha512-iQ9KTTmmN5fhfc2KMR7CcDblvcrg1QQ4pXymqZ3cRZF8L0890YLBcEqlIsGPdxoFwghyN8RA1pCEhCKuTF4Lkw==
worker-plugin@3.2.0:
version "3.2.0"
resolved "https://registry.yarnpkg.com/worker-plugin/-/worker-plugin-3.2.0.tgz#ddae9f161b76fcbaacf8f54ecd037844584e43e7"
integrity sha512-W5nRkw7+HlbsEt3qRP6MczwDDISjiRj2GYt9+bpe8A2La00TmJdwzG5bpdMXhRt1qcWmwAvl1TiKaHRa+XDS9Q==
dependencies:
loader-utils "^1.1.0"

Expand Down

0 comments on commit 09d2f04

Please sign in to comment.