fix: using multiple unnamed Web Workers mixes them up #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When no name is provide use the workerId as identifier as otherwise we end up with only a single worker emitted. Fixes angular/angular-cli#15188 and fixes angular/angular-cli#14582 and fixes #24
developit
approved these changes
Aug 13, 2019
|
@developit when do you think there'll be a release that includes this fix? |
mgechev
pushed a commit
to angular/angular-cli
that referenced
this pull request
Aug 28, 2019
…5456) includes this fix GoogleChromeLabs/worker-plugin#35 which solves the below issues. Fixes #15188 and fixes #14582
mgechev
pushed a commit
to angular/angular-cli
that referenced
this pull request
Aug 28, 2019
…5456) includes this fix GoogleChromeLabs/worker-plugin#35 which solves the below issues. Fixes #15188 and fixes #14582
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no name is provide use the workerId as identifier as otherwise we end up with only a single worker emitted.
Fixes angular/angular-cli#15188 and fixes angular/angular-cli#14582 and fixes #24