Skip to content

Commit

Permalink
fix: Enforce loglevel warn for npm-install
Browse files Browse the repository at this point in the history
The npm call uses the node exec() call which has a default limit
of 200kb after which the process is terminated.
When the user has set the info loglevel ng new terminates without
any helpful error message. When using --quiet the loglevel is
set to warning in any case resulting in a successful build.
This is especially important for users of docker since the current
node base image sets the loglevel to info.
  • Loading branch information
Thomas Kruse authored and Thomas Kruse committed Feb 25, 2017
1 parent a6289f8 commit 0d3dc7e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/@angular/cli/tasks/npm-install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export default Task.extend({

return new Promise(function(resolve, reject) {
ui.writeLine(chalk.green(`Installing packages for tooling via ${packageManager}.`));
exec(`${packageManager} install`,
exec(`${packageManager} --quiet install`,
(err: NodeJS.ErrnoException, _stdout: string, stderr: string) => {
if (err) {
ui.writeLine(stderr);
Expand Down

0 comments on commit 0d3dc7e

Please sign in to comment.