Skip to content

Commit

Permalink
build: rename //:node_modules to root modules
Browse files Browse the repository at this point in the history
In our dev-infra sync we decided that we want to have less
ambiguous naming for node modules from the workspace root vs. node
modules that are local to the package.

Consider the confusion between: `//:node_modules` and `:node_modules`.
This commit fixes this by naming the workspace `node_modules` as
`:root_modules`. This does not have an effect on runtime of NodeJS
output because `rules_js` continues to lay out the root modules as
`/node_modules` folder; as it should.
  • Loading branch information
devversion authored and clydin committed Dec 16, 2024
1 parent 6006f59 commit 4100402
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ exports_files([
])

npm_link_all_packages(
name = "node_modules",
name = "root_modules",
)

rules_js_tsconfig(
name = "build-tsconfig",
src = "tsconfig-build.json",
deps = [
"tsconfig.json",
"//:node_modules/@types/node",
"//:root_modules/@types/node",
],
)

Expand All @@ -40,7 +40,7 @@ rules_js_tsconfig(
src = "tsconfig-test.json",
deps = [
"tsconfig.json",
"//:node_modules/@types/node",
"//:root_modules/@types/node",
],
)

Expand Down
8 changes: 4 additions & 4 deletions packages/angular_devkit/architect/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ ts_project(
],
module_name = "@angular-devkit/architect",
deps = [
"//:node_modules/@types/node",
"//:node_modules/rxjs",
"//:root_modules/@types/node",
"//:root_modules/rxjs",
],
)

Expand All @@ -84,8 +84,8 @@ ts_project(
],
deps = [
":architect_rjs",
"//:node_modules/@types/jasmine",
"//:node_modules/rxjs",
"//:root_modules/@types/jasmine",
"//:root_modules/rxjs",
"//packages/angular_devkit/architect/testing:testing_rjs",
],
)
Expand Down
4 changes: 2 additions & 2 deletions packages/angular_devkit/architect/testing/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ts_project(
],
module_name = "@angular-devkit/architect/testing",
deps = [
"//:node_modules/@types/node",
"//:node_modules/rxjs",
"//:root_modules/@types/node",
"//:root_modules/rxjs",
],
)

0 comments on commit 4100402

Please sign in to comment.