Skip to content

Unicode comment is not compatible with Angular-CLI in app.module.ts #10095

Closed
@KaiserKatze

Description

@KaiserKatze

Versions

Angular CLI: 1.7.3
Node: 8.9.4
OS: win32 x64
Angular: 5.2.9
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

@angular/cdk: 5.2.4
@angular/cli: 1.7.3
@angular/material: 5.2.4
@angular-devkit/build-optimizer: 0.3.2
@angular-devkit/core: 0.3.2
@angular-devkit/schematics: 0.3.2
@ngtools/json-schema: 1.2.0
@ngtools/webpack: 1.10.2
@schematics/angular: 0.3.2
@schematics/package-update: 0.3.2
typescript: 2.5.3
webpack: 3.11.0

Repro steps

  • Step 1
    Insert Unicode strings (let's say Chinese) as comments before import block;
  • Step 2
    Run any generate command, such as:
ng generate component TestUnicode
  • Step 3
    Open app.module.ts, you will find Angular-CLI inserted the new import phrase at wrong location instead of appending it at the end of import block;
  • Step 4
    Remove Unicode commend, the Earth rotates again.

Observed behavior

Desired behavior

  1. Please notify new Angular developers Unicode/UTF-8 is not fully supported by Angular-CLI;
  2. I wish Angular-CLI support Unicode comments in app.module.ts in the future.

Mention any other details that might be useful (optional)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions