Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webapp Manifest icons are generated with invalid paths #1179

Closed
Splaktar opened this issue Jun 23, 2016 · 1 comment
Closed

Webapp Manifest icons are generated with invalid paths #1179

Splaktar opened this issue Jun 23, 2016 · 1 comment
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix

Comments

@Splaktar
Copy link
Member

  1. Mac OS-X El Capitan
  2. Versions.
    angular-cli: 1.0.0-beta.6
    node: 4.4.3
    os: darwin x64
  3. Repro steps.
    ng new myApp --mobile
  4. The log given by the failure.
    N/A.
  5. Mention any other details that might be useful.
    The icon section of the manifest currently generated by the angular-cli looks like this:
  "icons": [
    {
            "src": "/android-chrome-36x36.png",
            "sizes": "36x36",
            "type": "image/png",
            "density": 0.75
        },
        {
            "src": "/android-chrome-48x48.png",
            "sizes": "48x48",
            "type": "image/png",
            "density": 1
        },
        {
            "src": "/android-chrome-72x72.png",
            "sizes": "72x72",
            "type": "image/png",
            "density": 1.5
        },
        {
            "src": "/android-chrome-96x96.png",
            "sizes": "96x96",
            "type": "image/png",
            "density": 2
        },
        {
            "src": "/android-chrome-144x144.png",
            "sizes": "144x144",
            "type": "image/png",
            "density": 3
        },
        {
            "src": "/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image/png",
            "density": 4
        }
  ],

This doesn't work since the icons are bundled into dist/icons and not just in dist/. To fix this, it needs to define the icon src like this:

   "icons": [
    {
            "src": "icons/android-chrome-36x36.png",
            "sizes": "36x36",
            "type": "image/png"
        },
        {
            "src": "icons/android-chrome-48x48.png",
            "sizes": "48x48",
            "type": "image/png"
        },
        {
            "src": "icons/android-chrome-72x72.png",
            "sizes": "72x72",
            "type": "image/png"
        },
        {
            "src": "icons/android-chrome-96x96.png",
            "sizes": "96x96",
            "type": "image/png"
        },
        {
            "src": "icons/android-chrome-144x144.png",
            "sizes": "144x144",
            "type": "image/png"
        },
        {
            "src": "icons/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image/png"
        }
  ],
Splaktar added a commit to DevIntent/angular-cli that referenced this issue Jun 23, 2016
fix 'Add to Homescreen' on mobile not finding icons

Fixes angular#1179
Splaktar added a commit to DevIntent/angular-cli that referenced this issue Jun 23, 2016
fix 'Add to Homescreen' on mobile not finding icons

Fixes angular#1179
@filipesilva filipesilva added type: bug/fix P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Jul 4, 2016
Splaktar added a commit to DevIntent/angular-cli that referenced this issue Jul 31, 2016
fix 'Add to Homescreen' on mobile not finding icons

Fixes angular#1179
Splaktar added a commit to DevIntent/angular-cli that referenced this issue Jul 31, 2016
add `icons/` path in front of icon `src` values

Fixes angular#1179
Splaktar added a commit to DevIntent/angular-cli that referenced this issue Jul 31, 2016
fix 'Add to Homescreen' on mobile not finding icons

Fixes angular#1179
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants