-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@schematics/angular --minimal still generate e2e project #12739
Comments
Don't run the e2e schematic when using application or ng-new schematics with option.minimal set to true. fix angular#12739
It looks like --minimal was removed in v6, but the documentation was never removed from --help. See #10982. --skip-tests will omit the spec files, but will leave e2e. |
@collinstevens see #12498 & #11904. |
Don't run the e2e schematic when using application or ng-new schematics with option.minimal set to true. fix angular#12739
…2742) * fix(@schematics/angular): --minimal should prevent generating e2e Don't run the e2e schematic when using application or ng-new schematics with option.minimal set to true. fix #12739 * style: inverse logic according to feedback * test(@schematics/angular): app and ng-new --minimal shouldn't generate e2e
…2742) * fix(@schematics/angular): --minimal should prevent generating e2e Don't run the e2e schematic when using application or ng-new schematics with option.minimal set to true. fix #12739 * style: inverse logic according to feedback * test(@schematics/angular): app and ng-new --minimal shouldn't generate e2e
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug Report or Feature Request (mark with an
x
)Command (mark with an
x
)Versions
Repro steps
Run ng new --minimal or ng g app --minimal.
The e2e schematic seems to have been executed anyway.
The log given by the failure
N/A
Desired functionality
Don't run the e2e schematic when using --minimal.
Mention any other details that might be useful
Will handle this asap with a PR, just creating the issue to remind me to do so 😉
The text was updated successfully, but these errors were encountered: