Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@schematics/angular --minimal still generate e2e project #12739

Closed
nweldev opened this issue Oct 24, 2018 · 3 comments · Fixed by #12742
Closed

@schematics/angular --minimal still generate e2e project #12739

nweldev opened this issue Oct 24, 2018 · 3 comments · Fixed by #12742
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Milestone

Comments

@nweldev
Copy link
Contributor

nweldev commented Oct 24, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [x] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 7.0.2
Node: 10.11.0
OS: linux x64
Angular: 
... 

Package                      Version
------------------------------------------------------
@angular-devkit/architect    0.10.2
@angular-devkit/core         7.0.2
@angular-devkit/schematics   7.0.2
@schematics/angular          7.0.2
@schematics/update           0.10.2
rxjs                         6.3.3
typescript                   3.1.3

Repro steps

Run ng new --minimal or ng g app --minimal.
The e2e schematic seems to have been executed anyway.

The log given by the failure

N/A

Desired functionality

Don't run the e2e schematic when using --minimal.

Mention any other details that might be useful

Will handle this asap with a PR, just creating the issue to remind me to do so 😉

nweldev pushed a commit to nweldev/angular-cli that referenced this issue Oct 24, 2018
Don't run the e2e schematic when using application or ng-new schematics
with option.minimal set to true.

fix angular#12739
@alan-agius4 alan-agius4 added type: bug/fix freq1: low Only reported by a handful of users who observe it rarely severity3: broken area: @schematics/angular labels Oct 25, 2018
@ngbot ngbot bot added this to the Backlog milestone Oct 25, 2018
@collinstevens
Copy link

It looks like --minimal was removed in v6, but the documentation was never removed from --help. See #10982. --skip-tests will omit the spec files, but will leave e2e.

@nweldev
Copy link
Contributor Author

nweldev commented Oct 25, 2018

@collinstevens see #12498 & #11904.

alexeagle pushed a commit to nweldev/angular-cli that referenced this issue Nov 1, 2018
Don't run the e2e schematic when using application or ng-new schematics
with option.minimal set to true.

fix angular#12739
alexeagle pushed a commit that referenced this issue Nov 1, 2018
…2742)

* fix(@schematics/angular): --minimal should prevent generating e2e

Don't run the e2e schematic when using application or ng-new schematics
with option.minimal set to true.

fix #12739

* style: inverse logic according to feedback

* test(@schematics/angular): app and ng-new --minimal shouldn't generate e2e
alexeagle pushed a commit that referenced this issue Nov 1, 2018
…2742)

* fix(@schematics/angular): --minimal should prevent generating e2e

Don't run the e2e schematic when using application or ng-new schematics
with option.minimal set to true.

fix #12739

* style: inverse logic according to feedback

* test(@schematics/angular): app and ng-new --minimal shouldn't generate e2e
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely severity3: broken type: bug/fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants