Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e script is created in package.json when --createApplication=false #13412

Closed
Ant59 opened this issue Jan 11, 2019 · 6 comments · Fixed by #16203
Closed

e2e script is created in package.json when --createApplication=false #13412

Ant59 opened this issue Jan 11, 2019 · 6 comments · Fixed by #16203
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely good first issue help wanted severity2: inconvenient type: bug/fix
Milestone
Backlog

Comments

@Ant59
Copy link

Ant59 commented Jan 11, 2019

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [x] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Node: v10.13.0
NPM: v6.4.1
Angular CLI: v7.1.3

Repro steps

  1. ng new --createApplication=false
  2. e2e script is added to package.json

Desired functionality

The e2e script should not be added to the package.json because no e2e directory or functionality is generated when createApplication flag is false.
@ngbot ngbot bot added this to the needsTriage milestone Jan 11, 2019
@ahasall
Copy link
Contributor

ahasall commented Jan 11, 2019

Hi @alan-agius4, I can fix this issue if you are okay with it.

@ngbot ngbot bot modified the milestones: needsTriage, Backlog May 13, 2019
@alan-agius4
Copy link
Collaborator

@shahata, sorry for the delay. You can take this is if you still want. However when adding an application we might want to add this.

@nadyafebi
Copy link

@alan-agius4 Is there anyone working on this issue? May I take it?

@ahasall
Copy link
Contributor

ahasall commented Oct 10, 2019

I am not working on the issue and I think no one is. So feel free to take it.

@alan-agius4
Copy link
Collaborator

@nadyafebi, feel free to take it.

@timdeschryver timdeschryver mentioned this issue Nov 16, 2019
Merged
alan-agius4 pushed a commit to timdeschryver/angular-cli that referenced this issue Aug 14, 2020
@timdeschryver @alan-agius4
fix(@schematics/angular): don't create e2e script when createApplicat…
9e9ab5b 
…ion is false

Bugfix for the ng new --createApplication=false command.
Currently, it creates an e2e script in package.json. This change will only add the script when the application is created.

Closes angular#13412
alan-agius4 pushed a commit that referenced this issue Aug 14, 2020
@timdeschryver @alan-agius4
fix(@schematics/angular): don't create e2e script when createApplicat…
a0e2f28 
…ion is false

Bugfix for the ng new --createApplication=false command.
Currently, it creates an e2e script in package.json. This change will only add the script when the application is created.

Closes #13412
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: @schematics/angular freq1: low Only reported by a handful of users who observe it rarely good first issue help wanted severity2: inconvenient type: bug/fix
Projects
None yet
Milestone
Backlog
5 participants
@Ant59 @ahasall @alan-agius4 @clydin @nadyafebi