Skip to content

additionalProperties at the builder level are allowed #14354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
FrozenPandaz opened this issue May 7, 2019 · 1 comment · Fixed by #14365
Closed

additionalProperties at the builder level are allowed #14354

FrozenPandaz opened this issue May 7, 2019 · 1 comment · Fixed by #14365

Comments

@FrozenPandaz
Copy link
Contributor

🐞 Bug report

Command (mark with an x)

All Architect commands

Is this a regression?

No, I do not believe this ever worked.

Description

If a builder schema can say it supports additionalProperties. However, when running the builder with an additional property, the following error appears:

Unknown option: '--additional'
Unknown option: 'property'

🔬 Minimal Reproduction

https://github.com/FrozenPandaz/angular-bugs/tree/additional-properties
ng run v8app:print --additional property

🔥 Exception or Error


Unknown option: '--additional'
Unknown option: 'property'

🌍 Your Environment


jason@pop-os:~/projects/temp/v8app$ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 8.0.0-rc.2
Node: 10.15.3
OS: linux x64
Angular: 8.0.0-rc.2
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.800.0-rc.2
@angular-devkit/build-angular     0.800.0-rc.2
@angular-devkit/build-optimizer   0.800.0-rc.2
@angular-devkit/build-webpack     0.800.0-rc.2
@angular-devkit/core              8.0.0-rc.2
@angular-devkit/schematics        8.0.0-rc.2
@ngtools/webpack                  8.0.0-rc.2
@schematics/angular               8.0.0-rc.2
@schematics/update                0.800.0-rc.2
rxjs                              6.4.0
typescript                        3.4.5
webpack                           4.30.0

Anything else relevant?
This is important for passing arguments into child processes.

Workarounds for this are ugly:

Workaround #1:
ng run v8app:print --args="--additional property" Where args is a string input.

No, should not matter.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
@clydin clydin removed their assignment Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants