Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n-locale should inject dir attribute #16047

Closed
ghost opened this issue Nov 2, 2019 · 3 comments · Fixed by #22210
Closed

i18n-locale should inject dir attribute #16047

ghost opened this issue Nov 2, 2019 · 3 comments · Fixed by #22210

Comments

@ghost
Copy link

ghost commented Nov 2, 2019

🚀 Feature request

Add dir="rtl" for rtl locales

Command (mark with an x)

- [ ] new
- [ x ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Description

A clear and concise description of the problem or missing capability...

Angular pages are always LTR, even when specifying an rtl language in i18n-locale parameter

Describe the solution you'd like

If you have a solution in mind, please describe it.

When running build with i18n-locale set to an RTL language such as Hebrew or Arabic, add dir="rtl" to html or body tags in index.html.
I know that the cli can modify the html, because base-href parameter does it

Describe alternatives you've considered

Have you considered any alternative solutions or workarounds?

Manually setting the dir tag, but then what happens if I want to support different build configs for rtl, and ltr locales? I will have to manually change the dir tag before every build.

@Talb2005
Copy link

Talb2005 commented Jun 2, 2021

Any progress with this issue?

@GabrielGil
Copy link

It would be great to have this in place, or some clarification on what's the best approach to serve an index.html that can have different dir attribute values.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants