Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ng update should have removed tslint setting no-use-before-declare #17117

Closed
1 of 15 tasks
johnpapa opened this issue Feb 28, 2020 · 4 comments · Fixed by #17203
Closed
1 of 15 tasks

ng update should have removed tslint setting no-use-before-declare #17117

johnpapa opened this issue Feb 28, 2020 · 4 comments · Fixed by #17203
Assignees
Labels
area: @schematics/angular feature Issue that requests a new feature
Milestone

Comments

@johnpapa
Copy link
Contributor

🐞 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

I ran ng update to v9. Then I ran npm run lint. I received this error

▶npm run lint

> heroes-angular@0.0.0 lint /Users/papa/_git/heroes-angular
> ng lint

Linting "heroes-angular"...
no-use-before-declare is deprecated. Since TypeScript 2.9. Please use the built-in compiler checks instead.
All files pass linting.

It seems I had a legacy setting in tslint.json for "no-use-before-declare": true,

It would be great if the ng update removed any deprecated tslint settings.

@alan-agius4 alan-agius4 added area: @schematics/angular needs: discussion On the agenda for team meeting to determine next steps feature Issue that requests a new feature labels Mar 4, 2020
@ngbot ngbot bot modified the milestone: Backlog Mar 4, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Mar 5, 2020

@mgechev, what is the current status of ESLint? If we're hoping to move towards that in the future, we'll need to decide how much support we want to give TSLint for the time being.

@mgechev
Copy link
Member

mgechev commented Mar 5, 2020

We're still in a process of evaluation. There are some performance concerns.

@dgp1130
Copy link
Collaborator

dgp1130 commented Mar 12, 2020

Since we'll still be support TSLint for the foreseeable future, we already need a migration to upgrade to TSLint 6.1. We can remove no-use-before-declare in that migration. This will need to be run manually in v9.x when it is ready, but will run automatically in v10 (assuming we don't migrate to ESLint by then).

@dgp1130 dgp1130 assigned dgp1130 and alan-agius4 and unassigned dgp1130 Mar 12, 2020
@dgp1130 dgp1130 removed the needs: discussion On the agenda for team meeting to determine next steps label Mar 12, 2020
mgechev pushed a commit that referenced this issue Mar 17, 2020
In tslint version 6, several recommanded rules have been removed in the following PRs:
palantir/tslint#4871 palantir/tslint#4312

With this migration we update the tslint depedency to 6+ and add back these rules in the user workspace `tslint.json` also we remove some deprecated rules.

Until version 10, this is an opt-in migration and users will need to run this manually with the below command:
```
ng update @angular/cli --migrate-only tslint-version-6
```

Closes: #17117
Reference: TOOL-1348
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: @schematics/angular feature Issue that requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants