bug(moment-adapter): "_rollupMoment__default is not defined" #17320

kaito3desuyo · 2020-03-26T02:36:03Z

(related with angular/angular#36248)

Reproduction

https://github.com/kaito3desuyo/angular-test

Steps to reproduce:

clone this repository
ng build --prod
npm i -g http-server
move root directory to dist/angular-test Folder
http-server
open http://localhost:8080

This issue only occurs with production builds.

Expected Behavior

Screen is displayed correctly

Actual Behavior

Screen goes blank with console error

Environment

Angular: 9.1.0
CDK/Material: 9.2.0
Browser(s): Chrome 80.0.3987.149
Operating System (e.g. Windows, macOS, Ubuntu): Windows 10 x64 1909 18363.720

The text was updated successfully, but these errors were encountered:

LanderBeeuwsaert · 2020-03-26T08:44:51Z

I'm also using the moment-adapter so most probably the cause is the same.

jnfaerch · 2020-03-26T08:58:04Z

Edit: Noted wrong package :/

Can recreate with "@angular-devkit/build-angular": "~0.901.0"

"Resolved" with "@angular-devkit/build-angular": "~0.900.7"

keserwan · 2020-03-26T12:15:13Z

Same here, @jnfaerch suggestion worked.

mgameover · 2020-03-26T16:32:07Z

Same issue: main.95606efb9a87c022e413.js:1 Uncaught ReferenceError: _rollupMoment__default is not defined
@jnfaerch suggestion worked

newargus · 2020-03-26T16:34:23Z

Same Here:

wasiddiqui · 2020-03-26T16:39:17Z

facing the same issue
tried to build with @angular-devkit/build-angular": "~0.900.7" but not working

mgameover · 2020-03-26T16:46:34Z

@wasiddiqui, ~0.907.0 worked for me.
My project is using another lib, that was also built with ~0.901.0. once I've rebuilt that lib and my project, the issue has gone.
So you might need to check your dependencies.

wasiddiqui · 2020-03-26T17:23:17Z

MY ISSUE RESOLVED by workaround
Steps

Allow "allowSyntheticDefaultImport":true in tsconfig.json under compilerOptions.
Change "@angular-devkit/build-angular": "~0.901.0" to @angular-devkit/build-angular": "~0.900.7"
Import moment like this

import * as _moment from 'moment';
import { default as _rollupMoment } from 'moment';
const moment = _rollupMoment || _moment;

npm install
ng build

blackholegalaxy · 2020-03-26T17:55:14Z

ISSUE RESOLVED

Issue is not resolved, this is a workaround. We should'nt have to downgrade or change moment import.

crisbeto · 2020-03-26T20:13:57Z

I spent some time investigating it and it's most-likely an issue with build-angular like mentioned above. I've narrowed it down to somewhere between 0.900.3 and 0.901.0-next.4. The issue comes from the following lines:

var Jg = n("wd/R");
const Zg = _rollupMoment__default || Jg

Compared to the ones from a working version:

Ng = n("wd/R"),
Vg = n.n(Ng).a || Ng

I'm transferring the issue over to the correct repo.

marsc · 2020-03-27T09:59:50Z

Same problem here in production build only with "@angular-devkit/build-angular": "~0.901.0". Downgraded for now.

LemonyPie · 2020-03-27T12:26:04Z

Have the same problem but with
main-es2015.8a5dc9b260c775d8aa4b.js:1 Uncaught ReferenceError: dragulaExpt__default is not defined ("@angular-devkit/build-angular": "~0.901.0")

TheParad0X · 2020-03-27T18:51:54Z

Same problem here after an update from Angular 9.0.5 to the latest

mikejunt · 2020-03-28T00:19:57Z

Yep, also seeing this issue with moment after upgrading

atsjo · 2020-03-28T00:30:08Z

Same

fpmk · 2020-03-29T12:26:25Z

any news?

pabloxn · 2020-03-30T08:16:13Z

Same problem

deepakgonda · 2020-03-30T10:51:57Z

Same problem with the production build.

acherniak · 2020-03-30T13:56:31Z

Any good news?

jasoninrapid · 2020-03-30T15:15:16Z

We're seeing the same problem on an Angular 8 to Angular 9 upgrade we did on March 26. Details:

ng2-dragular module got transpiled with the same bad "dragulaExpt__default" referenced above.
Downgrading angular devkit fix it for us. Our (fixed) entry in the dev dependencies in package.json looks like: "@angular-devkit/build-angular": "0.900.7"

Fixes: #17320

JosepAlacid · 2020-04-06T18:34:01Z

I just don't understand how to apply @mgechev fix or I don't understand why this issue is closed.

mgechev · 2020-04-06T18:37:34Z

@JosepAlacid the issue is fixed by this PR #17364. We'll release the fix on Wednesday.

JosepAlacid · 2020-04-06T20:20:19Z

I will go on until then with the "window['_rollupMoment__default'] = null;" workaround.
Thanks for your kind response.

danielehrhardt · 2020-04-06T21:15:16Z

spock123 · 2020-04-06T22:10:51Z

@danielehrhardt Is that with @mgechev 's fix or?

danielehrhardt · 2020-04-06T22:15:37Z

@danielehrhardt Is that with @mgechev 's fix or?

Yes

mgechev · 2020-04-06T22:16:32Z

The fix is not our yet. @danielehrhardt did you build the CLI from source?

mtpultz · 2020-04-07T21:06:48Z

Downgrading the devkit has problems if you run npm audit fix in your deployments. This seemed to fix it until a couple days ago and now we're getting an error

An unhandled exception occurred: Cannot find module 'webpack-dev-server

So we've switched to the solution of adding window['_rollupMoment__default'] = null; to polyfills.ts

gultyayev · 2020-04-08T11:15:08Z

@JosepAlacid the issue is fixed by this PR #17364. We'll release the fix on Wednesday.

Still not working. Just updated my deps to the latest ones and still same error.

cedricduffournet · 2020-04-08T11:18:45Z

I think this is because angular-cli has not been released yet, still in v9.1.0.

OckePocke · 2020-04-08T18:55:09Z

I tried the new version 9.1.1, that has been released today, and it solved the issue for me.

mgechev · 2020-04-08T20:35:46Z

As @OckePocke mentioned, we released CLI 9.1.1 today. If the problem still persist for you, feel free to open a new issue linking this one.

Rajarml · 2020-04-09T08:25:33Z

The 9.1.1 CLI release seems to have fixed the same issue I got.
No more window['_rollupMoment__default'] = null;-in-polyfills.ts workaround needed.

whyvrafvr · 2020-04-09T10:30:16Z

No more window['_rollupMoment__default'] = null; but Moment imports should be updated like there : https://stackblitz.com/angular/qrmxxmanejy?file=src%2Fapp%2Fdatepicker-views-selection-example.ts

JosepAlacid · 2020-04-09T11:46:33Z

And don't forget to add
"allowSyntheticDefaultImports": true,
at compilerOptins in tsconfig.json

whyvrafvr · 2020-04-09T13:17:02Z

And don't forget to add
"allowSyntheticDefaultImports": true,
at compilerOptins in tsconfig.json

@JosepAlacid indeed 😉

hamfastgamgee · 2020-04-09T23:40:20Z

This fix made my "ng test" configuration use Typescript 3.6, meaning that any files using the safe navigation (Elvis) operator don't compile correctly. Is there something special I need to do (angular.json edits, etc.) so that only build optimization is impacted?

mgechev · 2020-04-10T05:30:19Z

@hamfastgamgee optional chaining (safe navigation, elvis, etc.) is part of TypeScript 3.7.

hamfastgamgee · 2020-04-10T11:55:26Z

@mgechev Right, and Angular 9.1.x supports 3.8. But after this fix to use 3.6 in the build optimizer, "ng test" is running as 3.6 for me, meaning that code is not working if it uses 3.7 or 3.8 features. I'm trying to figure out if it's something wrong in my config that's causing "ng test" to use the wrong TS version, or if this effectively causes TS 3.7+ to be unsupported again and should have been documented more explicitly.

JACrazy · 2020-04-17T23:08:00Z

Sad to see we're back to 3.6, was really liking optional chaining

mgechev · 2020-04-18T03:52:41Z

@JACrazy no need to go back to 3.6. We fixed this issue and published the fix on npm.

JACrazy · 2020-04-18T06:43:10Z

@JACrazy no need to go back to 3.6. We fixed this issue and published the fix on npm.

Great to hear!

angular-automatic-lock-bot · 2020-05-19T08:03:12Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

crisbeto self-assigned this Mar 26, 2020

crisbeto removed their assignment Mar 26, 2020

crisbeto transferred this issue from angular/components Mar 26, 2020

alan-agius4 added comp: devkit/build-optimizer freq3: high severity5: regression type: bug/fix labels Mar 27, 2020

ngbot bot added this to the Backlog milestone Mar 27, 2020

oBusk mentioned this issue Mar 27, 2020

Angular 9.1 - getAngularJSGlobal is not defined ui-router/angular-hybrid#412

Closed

ghost mentioned this issue Mar 28, 2020

[bug report] Does not work with Angular 9.1.0 valor-software/ng2-dragula#994

Closed

5 tasks

alan-agius4 mentioned this issue Apr 6, 2020

material-moment-adapter doesn't work in build-angular@0.901 #17396

Closed

15 tasks

mgechev closed this as completed in #17364 Apr 6, 2020

mgechev pushed a commit that referenced this issue Apr 6, 2020

fix(@angular-devkit/build-optimizer): use TypeScript 3.6

4509d3c

Fixes: #17320

mgechev pushed a commit that referenced this issue Apr 6, 2020

fix(@angular-devkit/build-optimizer): use TypeScript 3.6

2885a93

Fixes: #17320

jerome-benoit mentioned this issue Apr 9, 2020

Various fixes: sap-labs-france/ev-dashboard#1398

Merged

linjie997 mentioned this issue Apr 20, 2020

Optional chaining and nullish coalescing not working anymore #17506

Closed

15 tasks

angular-automatic-lock-bot bot locked and limited conversation to collaborators May 19, 2020

bug(moment-adapter): "_rollupMoment__default is not defined" #17320

bug(moment-adapter): "_rollupMoment__default is not defined" #17320

Comments

kaito3desuyo commented Mar 26, 2020

Reproduction

Expected Behavior

Actual Behavior

Environment

LanderBeeuwsaert commented Mar 26, 2020

jnfaerch commented Mar 26, 2020 • edited Loading

keserwan commented Mar 26, 2020

mgameover commented Mar 26, 2020 • edited Loading

newargus commented Mar 26, 2020

wasiddiqui commented Mar 26, 2020 • edited Loading

mgameover commented Mar 26, 2020 • edited Loading

wasiddiqui commented Mar 26, 2020 • edited Loading

import * as _moment from 'moment'; import { default as _rollupMoment } from 'moment'; const moment = _rollupMoment || _moment;

blackholegalaxy commented Mar 26, 2020

crisbeto commented Mar 26, 2020 • edited Loading

marsc commented Mar 27, 2020

LemonyPie commented Mar 27, 2020 • edited Loading

TheParad0X commented Mar 27, 2020

mikejunt commented Mar 28, 2020

atsjo commented Mar 28, 2020

fpmk commented Mar 29, 2020

pabloxn commented Mar 30, 2020

deepakgonda commented Mar 30, 2020

acherniak commented Mar 30, 2020

jasoninrapid commented Mar 30, 2020

JosepAlacid commented Apr 6, 2020

mgechev commented Apr 6, 2020

JosepAlacid commented Apr 6, 2020

danielehrhardt commented Apr 6, 2020

spock123 commented Apr 6, 2020

danielehrhardt commented Apr 6, 2020

mgechev commented Apr 6, 2020

mtpultz commented Apr 7, 2020

gultyayev commented Apr 8, 2020

cedricduffournet commented Apr 8, 2020

OckePocke commented Apr 8, 2020

mgechev commented Apr 8, 2020

Rajarml commented Apr 9, 2020 • edited Loading

whyvrafvr commented Apr 9, 2020

JosepAlacid commented Apr 9, 2020

whyvrafvr commented Apr 9, 2020

hamfastgamgee commented Apr 9, 2020

mgechev commented Apr 10, 2020

hamfastgamgee commented Apr 10, 2020

JACrazy commented Apr 17, 2020

mgechev commented Apr 18, 2020 • edited Loading

JACrazy commented Apr 18, 2020

angular-automatic-lock-bot bot commented May 19, 2020

jnfaerch commented Mar 26, 2020 •

edited

Loading

mgameover commented Mar 26, 2020 •

edited

Loading

wasiddiqui commented Mar 26, 2020 •

edited

Loading

mgameover commented Mar 26, 2020 •

edited

Loading

wasiddiqui commented Mar 26, 2020 •

edited

Loading

import * as _moment from 'moment';
import { default as _rollupMoment } from 'moment';
const moment = _rollupMoment || _moment;

crisbeto commented Mar 26, 2020 •

edited

Loading

LemonyPie commented Mar 27, 2020 •

edited

Loading

Rajarml commented Apr 9, 2020 •

edited

Loading

mgechev commented Apr 18, 2020 •

edited

Loading