Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability with acorn #17899

Closed
vishnutsivan opened this issue Jun 10, 2020 · 7 comments · Fixed by #17898
Closed

Vulnerability with acorn #17899

vishnutsivan opened this issue Jun 10, 2020 · 7 comments · Fixed by #17898
Labels
Milestone

Comments

@vishnutsivan
Copy link

vishnutsivan commented Jun 10, 2020

🐞 Bug report

Our security check tool is throwing a vulnerability issue with acorn 6.3.0

Description

@angular-devkit/build-angular@0.901.7 is dependent on less version 3.11.1 which has dependency with acorn@6.3.0.

Possible Fix

We think we can solve this issue by updating less to version 3.11.3

Please have a look on pull request #17898

@alan-agius4
Copy link
Collaborator

Hi @vishnutsivan, can you please share the vulnerability report? less 3.11.1 doesn't depend on acorn.

https://unpkg.com/browse/less@3.11.1/package.json

@alan-agius4 alan-agius4 added the needs: more info Reporter must clarify the issue label Jun 10, 2020
@vishnutsivan
Copy link
Author

@alan-agius4 in package.json of less 3.11.1 there is no dependency on acorn. But if we browse node_modules then we can find it's reference
image

@alan-agius4
Copy link
Collaborator

@vishnutsivan I see, the used to ship a node_modules directory as part of the package.

@vishnutsivan
Copy link
Author

@alan-agius4 yes, and in the latest version of less ie 3.11.3 there are no such shipping of node_modules

@alan-agius4
Copy link
Collaborator

Note: this security notuice doesn't effect package manager audit tools such as NPM and Yarn.

@vishnutsivan, left you a couple of comments on the PR, thanks.

@alan-agius4
Copy link
Collaborator

Closing via #17898

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants